Re: [PATCH v2 15/37] GDB: testsuite: base: Don't return value from top-level (manual)

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Thiago Jung Bauermann <thiago.bauermann@linaro.org> writes:

> diff --git a/gdb/testsuite/gdb.base/corefile-buildid.exp b/gdb/testsuite/gdb.base/corefile-buildid.exp
> index 45c613b528ff..2f5ea644081f 100644
> --- a/gdb/testsuite/gdb.base/corefile-buildid.exp
> +++ b/gdb/testsuite/gdb.base/corefile-buildid.exp
> @@ -215,17 +215,17 @@ proc locate_exec_from_core_build_id {corefile buildid \
>  foreach_with_prefix mode { exec shared } {
>      # Build the executable.
>      set progname ${binfile}-$mode
>      set build_proc build_corefile_buildid_${mode}
>      if { ![$build_proc $progname] } {
> -	return -1
> +	return
>      }
>  
>      # Generate a corefile.
>      set corefile [create_core_file $progname]
>      if { $corefile eq "" } {
> -	return -1
> +	return
>      }
>  
>      # Get the build-id filename without ".debug" on the end.  This
>      # will have the format: '.build-id/xx/xxxxx'
>      set buildid [build_id_debug_filename_get $progname ""]

Just for the record, I dropped this change because the testcase was
already fixed by a recent commit restructuring it.

-- 
Thiago