From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3TcxKXFd/mmEeCQAWB0awg (envelope-from ) for ; Fri, 08 May 2026 18:02:25 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=GrgQaNv4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 91D8D1E0BA; Fri, 08 May 2026 18:02:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7B7BD1E067 for ; Fri, 08 May 2026 18:02:24 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1F3174BA2E1A for ; Fri, 8 May 2026 22:02:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F3174BA2E1A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=GrgQaNv4 Received: from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com [IPv6:2607:f8b0:4864:20::a2b]) by sourceware.org (Postfix) with ESMTPS id AB5504BA2E06 for ; Fri, 8 May 2026 22:01:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB5504BA2E06 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AB5504BA2E06 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a2b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778277718; cv=none; b=HGvoAZWOooUxvbuCUwACwUTx//hSpyJh7Xvn1fq45FOR3So8W/C813NI1bn+9NavtdwXOINhgXj51a2SrhqHfssyBgwqcy+8pXOnv8U+ly5c9CEf7o+jV4sFQonQNxRWHtrbf/S6xDDjPUWSGjkm2uzM7q/DB5RcYkzc5NjvG60= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778277718; c=relaxed/simple; bh=e8vK4TI4ZtJEFsIE9dU67Dj3yLk6kbetis2VZSmgk8s=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eRe3+2IpNM2pJplKK/Jky+QJOmldAdiOhQd81pGcO/8spX910OPKYc8A1NiheTPaJGun1+DDsoZb78HhKIUPwm3Zl8L7MQubsf4ugRnCZk4R+26cho0IVMmmWMeMLKoUQ9lfYB+qq0VJ9xNK5Ak1OPpEL7VEtSUqx+Wj6iVd1EI= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=GrgQaNv4 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AB5504BA2E06 Received: by mail-vk1-xa2b.google.com with SMTP id 71dfb90a1353d-573a81abef0so1592590e0c.2 for ; Fri, 08 May 2026 15:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778277718; x=1778882518; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=C1Y1duwsJ0Qh2LksvwR8IPiME1Tp78SSfv1hOoOgJfk=; b=GrgQaNv4G+HwU/enzTzj9lgbWN1l4qrB52pUrkOsdF8I3b46yj3l8kjrpcxoXStqN9 rD8DhK/4oc1xSQoigU4bd7gmBI3lM+yQFdp7hM0rkShGqGUy0rcu1UO3rb9jusNqbeW+ CfVBHMSHSXQFvU1m/+4g07HwEOUa8eiq6gfd+PHalwss/akR3cymYmmw05XSwhIoxJRH a5+0/0nXxBqSu/b0TPscpFV35AgiDKfMp7aUk0hAmqKYZVtDTgLc08A42KdErpHeW3g+ KU/N/M35DHaMuBTdI6zKuRqRLOgJLyQ6WTkKSiB7r5Kfpoqz0Hbt8mUZhNXsJV6MN7ZO t5Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778277718; x=1778882518; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C1Y1duwsJ0Qh2LksvwR8IPiME1Tp78SSfv1hOoOgJfk=; b=dd4e1rs0JxUSmkLDYjSw3zAEjEhB+B4Q3ZX1XguIz1nljuOtEBwf9sF0xZnnG123B2 gmz+c95yu2WtBRXAt4crmS1CeEZLb8mcI5C8c06XSoWlFo90XfXS9AP321qEo4VejNOK nR4jsdH5WKtW7HejAKPbZM14dckOsjVbVBwyEZkgNp90GmW8am/FynfLrY8zSptqI1Ie ZxaYbzIgJuFB+JGG/Alsa798ndnSAVdTze7WFtSoL4TP632YiNdbAhqGaikK60xactOA n+WDau8kWgp7OTjfznuRiuyFbNCsIyTDTF1XokmA7kT8ClUgMF3FAADtSZ7yVLlR2dfZ c0Ug== X-Gm-Message-State: AOJu0YzhXO8VDSNYLtbIG6E295Gvo0vsPKfIq8Fzs5MuRzP/HJsAQj2p +ueMyCMp26IRk1X0LzJyOBcZGZuZV7utzOn39W2KH+WvbzKJHnbgGinSls1dvss0OMXBipLE50d 8dcdj X-Gm-Gg: Acq92OHlxwZWira8asV/FZbrnbQK7IPYXcyP9Spb2t/KQAe5Fj1oWIbKsIc9u2DykAA U584z9fUa9oY6AmYle7o5gI5AW6bP/53+BaYtMeSNQxXt7rwoGW+95ZG2nfawaFClEprfQsXesH /3U98M746d6+nmJmdb6c5xpvOkYfmBvtpYkDAH1TY+I5qDqdK6k5dzSdPNe/GfIqkDLqn/fBgE2 webjApMsE9IDt0tv9BrIMuOubT+eunbkRFAt+WodbY1E6u3DwxH++4iyuz7iRnSpmKG9FohfsXZ lzRQKTA1c4IHNCxBQC324F+UsjbmdRAi5oWaXNVZh+JEdkzpAgn78/XuKRn9FGtPVAuNnnynl3L 6cA/BZiiNv6HlHGqbZNrpmazzir3Udm7t0rCzma+8JEmg2qTN/z/OvATv6U7VStMtttGHgPLT7J vMnlIbis6N3rmRk80= X-Received: by 2002:a05:6122:e169:b0:575:33d4:d101 with SMTP id 71dfb90a1353d-575594f69c1mr9015050e0c.2.1778277718066; Fri, 08 May 2026 15:01:58 -0700 (PDT) Received: from localhost ([2804:14d:5c5b:48de::33b7]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-95f219c6d64sm1641295241.3.2026.05.08.15.01.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 15:01:57 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: Re: [PATCH v2 15/37] GDB: testsuite: base: Don't return value from top-level (manual) In-Reply-To: <20260429230432.60487-16-thiago.bauermann@linaro.org> (Thiago Jung Bauermann's message of "Wed, 29 Apr 2026 20:04:06 -0300") References: <20260429230432.60487-1-thiago.bauermann@linaro.org> <20260429230432.60487-16-thiago.bauermann@linaro.org> User-Agent: mu4e 1.14.1; emacs 30.2 Date: Fri, 08 May 2026 19:01:54 -0300 Message-ID: <87o6ipd0h9.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Thiago Jung Bauermann writes: > diff --git a/gdb/testsuite/gdb.base/corefile-buildid.exp b/gdb/testsuite/gdb.base/corefile-buildid.exp > index 45c613b528ff..2f5ea644081f 100644 > --- a/gdb/testsuite/gdb.base/corefile-buildid.exp > +++ b/gdb/testsuite/gdb.base/corefile-buildid.exp > @@ -215,17 +215,17 @@ proc locate_exec_from_core_build_id {corefile buildid \ > foreach_with_prefix mode { exec shared } { > # Build the executable. > set progname ${binfile}-$mode > set build_proc build_corefile_buildid_${mode} > if { ![$build_proc $progname] } { > - return -1 > + return > } > > # Generate a corefile. > set corefile [create_core_file $progname] > if { $corefile eq "" } { > - return -1 > + return > } > > # Get the build-id filename without ".debug" on the end. This > # will have the format: '.build-id/xx/xxxxx' > set buildid [build_id_debug_filename_get $progname ""] Just for the record, I dropped this change because the testcase was already fixed by a recent commit restructuring it. -- Thiago