[PATCH v2 20/37] GDB: testsuite: GDB: Don't return -1 from top-level

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

All changes except for one are the result of running:

$ sed -i 's/^    return -1/    return/' *.exp

inside gdb/testsuite/gdb.gdb.  The exception is a return statement in
index-file.exp, which is inside a with_timeout_factor block.
---
 gdb/testsuite/gdb.gdb/index-file.exp    | 8 ++++----
 gdb/testsuite/gdb.gdb/python-helper.exp | 2 +-
 gdb/testsuite/gdb.gdb/unittest.exp      | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/gdb/testsuite/gdb.gdb/index-file.exp b/gdb/testsuite/gdb.gdb/index-file.exp
index 162ba28bfde1..d0c845302fc2 100644
--- a/gdb/testsuite/gdb.gdb/index-file.exp
+++ b/gdb/testsuite/gdb.gdb/index-file.exp
@@ -25,18 +25,18 @@ require !readnow
 set timeout_factor 20
 
 set filename [selftest_prepare]
 if { $filename eq "" } {
     unsupported "${gdb_test_file_name}.exp"
-    return -1
+    return
 }
 
 # If FILENAME is a libtool wrapper, then we need to get the path of the real
 # executable.
 set filename [selftest_libtool_get_real_gdb_executable $filename]
 if { $filename eq "" } {
-    return -1
+    return
 }
 
 with_timeout_factor $timeout_factor {
     # Start GDB, load FILENAME.
     clean_restart
@@ -46,11 +46,11 @@ with_timeout_factor $timeout_factor {
 # Record how many worker threads GDB is using.
 set worker_threads [gdb_get_worker_threads]
 
 if { $worker_threads eq "UNKNOWN" } {
     unresolved "unable to get worker thread count"
-    return -1
+    return
 }
 
 # Generate an index file.
 set dir1 [standard_output_file "index_1"]
 remote_exec host "mkdir -p ${dir1}"
@@ -64,11 +64,11 @@ with_timeout_factor $timeout_factor {
 	    pass $gdb_test_name
 	    set ok 1
 	}
     }
     if { ! $ok } {
-	return -1
+	return
     }
 
     gdb_test_no_output "save gdb-index -dwarf-5 $dir1" \
 	"create dwarf-index files"
 }
diff --git a/gdb/testsuite/gdb.gdb/python-helper.exp b/gdb/testsuite/gdb.gdb/python-helper.exp
index b39f51de44fe..8f00ce920af3 100644
--- a/gdb/testsuite/gdb.gdb/python-helper.exp
+++ b/gdb/testsuite/gdb.gdb/python-helper.exp
@@ -24,11 +24,11 @@ require {!target_info exists gdb,noinferiorio}
 require allow_python_tests
 
 standard_testfile .cc
 
 if { [build_executable "failed to build" $testfile $srcfile {debug c++}] } {
-    return -1
+    return
 }
 
 # Find the helper script in the GDB build directory.
 set py_helper_script [file dirname $GDB]/gdb-gdb.py
 if { ![file readable $py_helper_script] \
diff --git a/gdb/testsuite/gdb.gdb/unittest.exp b/gdb/testsuite/gdb.gdb/unittest.exp
index 29e4206cb309..26870a7a0b7a 100644
--- a/gdb/testsuite/gdb.gdb/unittest.exp
+++ b/gdb/testsuite/gdb.gdb/unittest.exp
@@ -22,11 +22,11 @@ load_lib completion-support.exp
 set do_xml_test [allow_xml_test]
 
 standard_testfile
 
 if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 proc run_selftests_1 {} {
     global decimal gdb_prompt