From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ecs2Ko+Q8mm9ZgQAWB0awg (envelope-from ) for ; Wed, 29 Apr 2026 19:13:19 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ddKf7qhG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A71021E093; Wed, 29 Apr 2026 19:13:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 236291E093 for ; Wed, 29 Apr 2026 19:13:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B77E84BB3BE9 for ; Wed, 29 Apr 2026 23:13:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B77E84BB3BE9 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ddKf7qhG Received: from mail-vk1-xa32.google.com (mail-vk1-xa32.google.com [IPv6:2607:f8b0:4864:20::a32]) by sourceware.org (Postfix) with ESMTPS id 135414358A57 for ; Wed, 29 Apr 2026 23:05:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 135414358A57 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 135414358A57 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503950; cv=none; b=wjSVpUiHBojExg+YrX4m2VzZbnzWj89cY6mje8bDj+naTOzEdMw71NQvDNdGc4a5GqWBkJv6tmA2XJtgAshBnMrz1R80+NFJxYgbfHbTDCCHETxhS0gk3p/SIS+XJ4AAuAtUjsxatall6KluPlEnPu39gIbpY+0czJdZGU+wddQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503950; c=relaxed/simple; bh=M3IM7D8uMnO0jfAwPmn5vBEIKoXP0qIssQCx016fVkY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=EnG3+ciAc2rsYjIqnMdnGW+1K6hVr6rwhubUAmZZ5pfie5hsqwSiwof9w0TDKpIJ5IHOndCrD4rgBoutSaBc273Jfuvs3CDxQvn4M7EREKUwcPWeZcWQ+7FY2Nzec7DDpecPy8xwWRcQVsJfbxT3LwjQYfDe8Tj5YIeWMbw8wRQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 135414358A57 Received: by mail-vk1-xa32.google.com with SMTP id 71dfb90a1353d-56eec951db1so102914e0c.3 for ; Wed, 29 Apr 2026 16:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777503949; x=1778108749; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=UxAQ12fWAwFjwK/WMFIDkEdzORNN63VBqdMwvHJqxBw=; b=ddKf7qhGt2YQKi24s+TF7RSPVnl1bFdNOHXpHBCuC1Bn8FaXlnXlu4eEtTOYov6qA4 kWb9iLrqTApDo23HaeEKMdEU1ZfjqYAQIyhrroCeRBkxu8kx7TyB+5QkC/qF14qBuJ+4 8bZo1ih809d9RviBFvCxqE8VR130Cwnxif2uiUDVxTujS5/9XHJFQ/sUHCf7CsCpaNz9 9aq8c6UidBNAGGLK7tQ1NExRg4kiW1b7QtN327CVbdkqVZ9KVL0TROjtLEigzlqrUJys zrIk/TkTW41AUYEflVW8s3ncpnbyA99eqRHthLDDKlTmgVRvkJWQcQ5srZxAo4RKS4t3 sp+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777503949; x=1778108749; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UxAQ12fWAwFjwK/WMFIDkEdzORNN63VBqdMwvHJqxBw=; b=IO9kYVHc+C87leDRWCayGru2lgWLdqk1iC/EMKVlEUCM++E9A0uLA55jBpEG0iwovK M2dN9VTol3ZP7qwCD2LIz3fgI18qwbhWGSTxzRn0wje88Cnh6wQOZqyiUI8ZcQqgD9uE AYOWVMIt5PN3mpQ1NQlceFiu3wfVg3mdaMmNunkUNMzlzKWbGmBDqbhsvpvDcNn9yreq Pb+LLmiNvPJCzAaTy9c9Pk09x9N90jcdfotJ3TWLCkLQRqR5+Nm+iqnZfrmORIsWO1O5 PqvBr9zKtB9wUaiEEVeV7YNwOYPmn/0o5mOaEdpQXDQ2SWpdZt18Uj7ckp1PQHd7d0WI PU/w== X-Gm-Message-State: AOJu0YxTI/HzBWlQmCwOEer8r1kBoIsSn8kf1oAGuRQJZwV/AXzqSgi+ eTosW+BLu0GcHtz1QtuXZpD2LDk55EpM1llyoGd+PLCCwJQwBmYXzpVYUJgkwWmITA9pz2XK1lb yK5PD X-Gm-Gg: AeBDievrz3mEKyZbo19if7tj8ZNXMKImm3/gpsZ258s7zF6CMVSDFCZdXz+ovzjp1zE 2b3KgaEFEtJNXksIFuecM0QGIF07DkzsPDz0JRs473lneyMBI8d0mFs4orBxOk9pS7e9lUnj6ml 7I2luphp1TRHAYymVlh7LinemnHvfYMowRuoSjDkUTGPT6xRMw5ZPPAP+DXUhgjiqBZCQGN465P XJbgTdYcKXPXnnAAWPZZxkfP1qnIYGudLhVVXFzYwjvJECj5kdoSb6aVwQ9TLaVm1P+ueVk1aZ5 Ktxm7y24HXE+GYc4SA3Vz4zGpKPKDxad1j6u152sJD3t2E2oxDnaRUDVZG4M/8JF3BQiQ/eZM+M N0qiNDchhy6IZILZVtg0eD3JaZSPTyCC21fS/QkvcBdCNnS/FhN+hG+upuonJtcVIl1emw9OGC0 xv4rub7+V6PT7+NAdpSsDMlCmKg5LJvQyssjPIThtJHojG X-Received: by 2002:a05:6122:790:b0:572:4f60:b8e6 with SMTP id 71dfb90a1353d-573c96f4495mr97178e0c.12.1777503949371; Wed, 29 Apr 2026 16:05:49 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-573b6df59edsm2040631e0c.14.2026.04.29.16.05.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 16:05:49 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH v2 20/37] GDB: testsuite: GDB: Don't return -1 from top-level Date: Wed, 29 Apr 2026 20:04:11 -0300 Message-ID: <20260429230432.60487-21-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260429230432.60487-1-thiago.bauermann@linaro.org> References: <20260429230432.60487-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org All changes except for one are the result of running: $ sed -i 's/^ return -1/ return/' *.exp inside gdb/testsuite/gdb.gdb. The exception is a return statement in index-file.exp, which is inside a with_timeout_factor block. --- gdb/testsuite/gdb.gdb/index-file.exp | 8 ++++---- gdb/testsuite/gdb.gdb/python-helper.exp | 2 +- gdb/testsuite/gdb.gdb/unittest.exp | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.gdb/index-file.exp b/gdb/testsuite/gdb.gdb/index-file.exp index 162ba28bfde1..d0c845302fc2 100644 --- a/gdb/testsuite/gdb.gdb/index-file.exp +++ b/gdb/testsuite/gdb.gdb/index-file.exp @@ -25,18 +25,18 @@ require !readnow set timeout_factor 20 set filename [selftest_prepare] if { $filename eq "" } { unsupported "${gdb_test_file_name}.exp" - return -1 + return } # If FILENAME is a libtool wrapper, then we need to get the path of the real # executable. set filename [selftest_libtool_get_real_gdb_executable $filename] if { $filename eq "" } { - return -1 + return } with_timeout_factor $timeout_factor { # Start GDB, load FILENAME. clean_restart @@ -46,11 +46,11 @@ with_timeout_factor $timeout_factor { # Record how many worker threads GDB is using. set worker_threads [gdb_get_worker_threads] if { $worker_threads eq "UNKNOWN" } { unresolved "unable to get worker thread count" - return -1 + return } # Generate an index file. set dir1 [standard_output_file "index_1"] remote_exec host "mkdir -p ${dir1}" @@ -64,11 +64,11 @@ with_timeout_factor $timeout_factor { pass $gdb_test_name set ok 1 } } if { ! $ok } { - return -1 + return } gdb_test_no_output "save gdb-index -dwarf-5 $dir1" \ "create dwarf-index files" } diff --git a/gdb/testsuite/gdb.gdb/python-helper.exp b/gdb/testsuite/gdb.gdb/python-helper.exp index b39f51de44fe..8f00ce920af3 100644 --- a/gdb/testsuite/gdb.gdb/python-helper.exp +++ b/gdb/testsuite/gdb.gdb/python-helper.exp @@ -24,11 +24,11 @@ require {!target_info exists gdb,noinferiorio} require allow_python_tests standard_testfile .cc if { [build_executable "failed to build" $testfile $srcfile {debug c++}] } { - return -1 + return } # Find the helper script in the GDB build directory. set py_helper_script [file dirname $GDB]/gdb-gdb.py if { ![file readable $py_helper_script] \ diff --git a/gdb/testsuite/gdb.gdb/unittest.exp b/gdb/testsuite/gdb.gdb/unittest.exp index 29e4206cb309..26870a7a0b7a 100644 --- a/gdb/testsuite/gdb.gdb/unittest.exp +++ b/gdb/testsuite/gdb.gdb/unittest.exp @@ -22,11 +22,11 @@ load_lib completion-support.exp set do_xml_test [allow_xml_test] standard_testfile if {[build_executable "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } proc run_selftests_1 {} { global decimal gdb_prompt