Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: printing pointers to global (data) variable on Windows...
Date: Mon, 20 Aug 2012 17:50:00 -0000	[thread overview]
Message-ID: <87mx1ph2qd.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120820150849.GQ2798@adacore.com> (Joel Brobecker's message of	"Mon, 20 Aug 2012 08:08:49 -0700")

Joel> +   By default, it is assumed that the symbol size can be determined,
Joel> +   which means that the "has_size" flag of the returned minimal symbol
Joel> +   is set to 1.

What about defaulting it to zero, applying the appended, and then fixing
up the fallout?

I could do the mechanics of this if you think it is ok; and if you plan
to go forward with this.

Tom

diff --git a/gdb/symtab.h b/gdb/symtab.h
index 5401b22..05bc706 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -361,7 +361,12 @@ struct minimal_symbol
 
 #define MSYMBOL_TARGET_FLAG_1(msymbol)  (msymbol)->target_flag_1
 #define MSYMBOL_TARGET_FLAG_2(msymbol)  (msymbol)->target_flag_2
-#define MSYMBOL_SIZE(msymbol)		(msymbol)->size
+#define MSYMBOL_SIZE(msymbol)		((msymbol)->size + 0)
+#define SET_MSYMBOL_SIZE(msymbol, sz)		\
+  do {						\
+    (msymbol)->size = sz;			\
+    (msymbol)->has_size = 1;			\
+  } while (0)
 #define MSYMBOL_TYPE(msymbol)		(msymbol)->type
 
 #include "minsyms.h"


  reply	other threads:[~2012-08-20 17:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16 15:23 Joel Brobecker
2012-08-16 20:07 ` Tom Tromey
2012-08-16 22:45   ` Joel Brobecker
2012-08-17 14:23     ` Tom Tromey
2012-08-17 23:16       ` Joel Brobecker
2012-08-20 15:09         ` Joel Brobecker
2012-08-20 17:50           ` Tom Tromey [this message]
2012-08-21 15:28             ` Joel Brobecker
2012-08-20 17:48         ` Tom Tromey
2012-08-21 15:36           ` Joel Brobecker
2012-09-05 14:44             ` Joel Brobecker
2012-09-06  1:28               ` asmwarrior
2012-09-06  1:44                 ` Joel Brobecker
2012-09-06  2:03                   ` asmwarrior
2012-09-10 19:08               ` Tom Tromey
2012-09-10 22:13                 ` Joel Brobecker
2012-09-11 13:49                   ` Tom Tromey
2012-09-11 21:27                     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mx1ph2qd.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox