From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: printing pointers to global (data) variable on Windows...
Date: Tue, 21 Aug 2012 15:28:00 -0000 [thread overview]
Message-ID: <20120821152740.GR2798@adacore.com> (raw)
In-Reply-To: <87mx1ph2qd.fsf@fleche.redhat.com>
> What about defaulting it to zero, applying the appended, and then fixing
> up the fallout?
I thought about that too, and got concerned about missing some places.
However, I very much like one thing about your patch, which is the fact
that it now forces the use of a "setter" to change the value of the
msymbol size, and that answers my main worry. And just because of the
"setter" alone, I'd go with this approach.
We could go with this appraoch independently of the has_size flag first,
and then add the flag. The one tiny concern is for readers that did not
set the size of zero-sized symbols because it knew that the default
was already zero.
> I could do the mechanics of this if you think it is ok; and if you plan
> to go forward with this.
Thanks for the kind offer - I brought this up, I should really be
doing the work...
--
Joel
next prev parent reply other threads:[~2012-08-21 15:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 15:23 Joel Brobecker
2012-08-16 20:07 ` Tom Tromey
2012-08-16 22:45 ` Joel Brobecker
2012-08-17 14:23 ` Tom Tromey
2012-08-17 23:16 ` Joel Brobecker
2012-08-20 15:09 ` Joel Brobecker
2012-08-20 17:50 ` Tom Tromey
2012-08-21 15:28 ` Joel Brobecker [this message]
2012-08-20 17:48 ` Tom Tromey
2012-08-21 15:36 ` Joel Brobecker
2012-09-05 14:44 ` Joel Brobecker
2012-09-06 1:28 ` asmwarrior
2012-09-06 1:44 ` Joel Brobecker
2012-09-06 2:03 ` asmwarrior
2012-09-10 19:08 ` Tom Tromey
2012-09-10 22:13 ` Joel Brobecker
2012-09-11 13:49 ` Tom Tromey
2012-09-11 21:27 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821152740.GR2798@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox