From: Tom Tromey <tromey@redhat.com>
To: Maxime Coste <frrrwww@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Add a gdb.events.frame_change event registry
Date: Tue, 30 Apr 2013 11:07:00 -0000 [thread overview]
Message-ID: <87mwshxeqk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1367002961-12311-4-git-send-email-frrrwww@gmail.com> (Maxime Coste's message of "Fri, 26 Apr 2013 21:02:41 +0200")
>>>>> "Maxime" == Maxime Coste <frrrwww@gmail.com> writes:
Maxime> + /* Note that frame_to_frame_object returns a borrowed reference,
Maxime> + so we don't need a decref here. */
Maxime> + py_frame = frame ? frame_info_to_frame_object (frame) : Py_None;
I don't think that comment is true.
Also we recently agreed in gdb to do explicit checks against NULL, so
"frame != NULL" here.
Maxime> + if (!py_frame || evpy_add_attribute (frame_change_event,
Likewise for py_frame.
Maxime> +emit_frame_change_event (struct frame_info* frame)
Space before the "*", not after.
Maxime> +
Maxime> +static void
Maxime> +python_frame_changed (struct frame_info *frame)
Every new function needs an introductory comment.
Maxime> + struct gdbarch *arch = frame ? get_frame_arch(frame) : target_gdbarch();
Space before open paren.
This patch needs a documentation change for the new Python API.
Tom
next prev parent reply other threads:[~2013-04-29 20:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 21:07 Add a python event registry for selected frame changes Maxime Coste
2013-04-26 21:09 ` [PATCH 1/3] Add a select_frame_reason enum parameter to select_frame Maxime Coste
2013-04-30 11:05 ` Tom Tromey
2013-04-30 11:53 ` Joel Brobecker
2013-05-06 16:54 ` Pedro Alves
2013-05-10 19:50 ` Tom Tromey
2013-05-14 13:23 ` Maxime Coste
2013-04-26 21:10 ` [PATCH 2/3] Add a frame_changed observer Maxime Coste
2013-04-30 10:51 ` Tom Tromey
2013-04-27 7:55 ` [PATCH 3/3] Add a gdb.events.frame_change event registry Maxime Coste
2013-04-30 11:07 ` Tom Tromey [this message]
2013-04-30 11:09 ` Tom Tromey
2013-04-30 10:53 ` Add a python event registry for selected frame changes Tom Tromey
2013-04-30 23:29 ` Maxime Coste
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwshxeqk.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=frrrwww@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox