From: Maxime Coste <frrrwww@gmail.com>
To: Pedro Alves <palves@redhat.com>, Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Add a select_frame_reason enum parameter to select_frame
Date: Tue, 14 May 2013 13:23:00 -0000 [thread overview]
Message-ID: <51923acc.ebbbb40a.3e42.0f2b@mx.google.com> (raw)
In-Reply-To: <5187E029.8070008@redhat.com>
Hello
On Mon, 06 May 2013 17:54:01 +0100, Pedro Alves <palves@redhat.com> wrote:
> IMO, it'd be better to leave select_frame unaware of why it's being
> called, and just add a wrapper for user visible frame selection.
> It feels like different conceptual levels to me. IOW, something like:
>
> void
> select_user_frame (struct frame_info *fi)
> [...]
That seems better to me too, I went the other way because at first I tried
to add checks for frame restoration (there were IMPL_DETAIL_{PUSH,POP}
with a counter checking that only IMPL_DETAIL_* were nested...
I'll prepare a patch using this approach.
> If we limit frame change notifications to user frame changes
> (CLI up/down/frame and MI equivalents), then these issues
> with stops would be non-issues by design...
Yes, this seems more reasonable as well.
Thanks for the review.
Maxime.
next prev parent reply other threads:[~2013-05-14 13:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 21:07 Add a python event registry for selected frame changes Maxime Coste
2013-04-26 21:09 ` [PATCH 1/3] Add a select_frame_reason enum parameter to select_frame Maxime Coste
2013-04-30 11:05 ` Tom Tromey
2013-04-30 11:53 ` Joel Brobecker
2013-05-06 16:54 ` Pedro Alves
2013-05-10 19:50 ` Tom Tromey
2013-05-14 13:23 ` Maxime Coste [this message]
2013-04-26 21:10 ` [PATCH 2/3] Add a frame_changed observer Maxime Coste
2013-04-30 10:51 ` Tom Tromey
2013-04-27 7:55 ` [PATCH 3/3] Add a gdb.events.frame_change event registry Maxime Coste
2013-04-30 11:07 ` Tom Tromey
2013-04-30 11:09 ` Tom Tromey
2013-04-30 10:53 ` Add a python event registry for selected frame changes Tom Tromey
2013-04-30 23:29 ` Maxime Coste
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51923acc.ebbbb40a.3e42.0f2b@mx.google.com \
--to=frrrwww@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox