From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18459 invoked by alias); 29 Apr 2013 20:29:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18450 invoked by uid 89); 29 Apr 2013 20:29:27 -0000 X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 29 Apr 2013 20:29:27 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3TKTOQ8009575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 29 Apr 2013 16:29:25 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3TKTNtc011077 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 29 Apr 2013 16:29:24 -0400 From: Tom Tromey To: Maxime Coste Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Add a gdb.events.frame_change event registry References: <1367002961-12311-1-git-send-email-frrrwww@gmail.com> <1367002961-12311-4-git-send-email-frrrwww@gmail.com> Date: Tue, 30 Apr 2013 11:07:00 -0000 In-Reply-To: <1367002961-12311-4-git-send-email-frrrwww@gmail.com> (Maxime Coste's message of "Fri, 26 Apr 2013 21:02:41 +0200") Message-ID: <87mwshxeqk.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00887.txt.bz2 >>>>> "Maxime" == Maxime Coste writes: Maxime> + /* Note that frame_to_frame_object returns a borrowed reference, Maxime> + so we don't need a decref here. */ Maxime> + py_frame = frame ? frame_info_to_frame_object (frame) : Py_None; I don't think that comment is true. Also we recently agreed in gdb to do explicit checks against NULL, so "frame != NULL" here. Maxime> + if (!py_frame || evpy_add_attribute (frame_change_event, Likewise for py_frame. Maxime> +emit_frame_change_event (struct frame_info* frame) Space before the "*", not after. Maxime> + Maxime> +static void Maxime> +python_frame_changed (struct frame_info *frame) Every new function needs an introductory comment. Maxime> + struct gdbarch *arch = frame ? get_frame_arch(frame) : target_gdbarch(); Space before open paren. This patch needs a documentation change for the new Python API. Tom