Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Svante Signell <svante.signell@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Small patch to enable build of gdb-7.6 for GNU/Hurd
Date: Thu, 23 May 2013 17:08:00 -0000	[thread overview]
Message-ID: <87mwrld3ps.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1369326967.8127.33.camel@s1499.it.kth.se> (Svante Signell's	message of "Thu, 23 May 2013 18:36:07 +0200")

>>>>> "Svante" == Svante Signell <svante.signell@gmail.com> writes:

Svante> In case you need feedback from me use Cc: since I'm not subscribed to
Svante> gdb-patches.

It needs a ChangeLog entry.

Svante> -  xsnprintf (arch_path, sizeof (arch_path), "%s/%s%s", nto_root, arch, endian);
Svante> +  arch_len = strlen (nto_root) + 1 + strlen (arch) + strlen (endian) + 1;
Svante> +  arch_path = alloca (arch_len);
Svante> +  xsnprintf (arch_path, arch_len, "%s/%s%s", nto_root, arch, endian);
 
Svante> -  xsnprintf (buf, sizeof (buf), "set solib-absolute-prefix %s", arch_path);
Svante> +  len = strlen (FMT) - 2 + strlen (arch_path) + 1;
Svante> +  buf =  alloca (len);
Svante> +  xsnprintf (buf, len, FMT, arch_path);
Svante>    execute_command (buf, 0);

I think it would be simpler to use a single xstrprintf plus a cleanup.

Tom


  reply	other threads:[~2013-05-23 17:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-23 16:36 Svante Signell
2013-05-23 17:08 ` Tom Tromey [this message]
2013-05-23 17:21   ` Svante Signell
2013-05-23 17:27     ` Tom Tromey
2013-05-23 17:54       ` Svante Signell
2013-05-24  3:01         ` Sergio Durigan Junior
2013-05-24  2:59 ` Sergio Durigan Junior
2013-05-24  4:27   ` Joel Brobecker
2013-05-24  8:53     ` Pedro Alves
2013-05-24  9:07       ` Svante Signell
2013-05-24  9:13         ` Sergio Durigan Junior
2013-05-27 11:41           ` Svante Signell
2013-05-27 12:10             ` Joel Brobecker
2013-05-27 12:21               ` Svante Signell
2013-05-27 13:48                 ` Svante Signell
2013-05-27 13:57                   ` Svante Signell
2013-05-27 14:31                     ` Joel Brobecker
2013-05-27 15:59                       ` Svante Signell
2013-05-29  9:26                         ` Joel Brobecker
2013-05-29 12:18                           ` Svante Signell
2013-05-27 16:03                       ` New patch: " Svante Signell
2013-05-29  9:42                         ` Joel Brobecker
2013-05-29 12:49                           ` Svante Signell
2013-05-27 14:55                   ` Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwrld3ps.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=svante.signell@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox