From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21484 invoked by alias); 23 May 2013 17:08:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21475 invoked by uid 89); 23 May 2013 17:08:03 -0000 X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_XS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 23 May 2013 17:08:03 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4NH81pT017586 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 23 May 2013 13:08:01 -0400 Received: from barimba (ovpn-113-72.phx2.redhat.com [10.3.113.72]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4NH7xFv004479 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 23 May 2013 13:08:00 -0400 From: Tom Tromey To: Svante Signell Cc: gdb-patches@sourceware.org Subject: Re: Small patch to enable build of gdb-7.6 for GNU/Hurd References: <1369326967.8127.33.camel@s1499.it.kth.se> Date: Thu, 23 May 2013 17:08:00 -0000 In-Reply-To: <1369326967.8127.33.camel@s1499.it.kth.se> (Svante Signell's message of "Thu, 23 May 2013 18:36:07 +0200") Message-ID: <87mwrld3ps.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00879.txt.bz2 >>>>> "Svante" == Svante Signell writes: Svante> In case you need feedback from me use Cc: since I'm not subscribed to Svante> gdb-patches. It needs a ChangeLog entry. Svante> - xsnprintf (arch_path, sizeof (arch_path), "%s/%s%s", nto_root, arch, endian); Svante> + arch_len = strlen (nto_root) + 1 + strlen (arch) + strlen (endian) + 1; Svante> + arch_path = alloca (arch_len); Svante> + xsnprintf (arch_path, arch_len, "%s/%s%s", nto_root, arch, endian); Svante> - xsnprintf (buf, sizeof (buf), "set solib-absolute-prefix %s", arch_path); Svante> + len = strlen (FMT) - 2 + strlen (arch_path) + 1; Svante> + buf = alloca (len); Svante> + xsnprintf (buf, len, FMT, arch_path); Svante> execute_command (buf, 0); I think it would be simpler to use a single xstrprintf plus a cleanup. Tom