From: Svante Signell <svante.signell@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>,
Pedro Alves <palves@redhat.com>,
gdb-patches@sourceware.org
Subject: Re: Small patch to enable build of gdb-7.6 for GNU/Hurd
Date: Wed, 29 May 2013 12:18:00 -0000 [thread overview]
Message-ID: <1369829899.30815.0.camel@G3620.my.own.domain> (raw)
In-Reply-To: <20130529092606.GD5751@adacore.com>
On Wed, 2013-05-29 at 13:26 +0400, Joel Brobecker wrote:
> > 2013-05-27 Svante Signell <svante.signell@gmail.com>
> >
> > * nto-tdep.c (nto_init_solib_absolute_prefix): Solve build
> > problems for systems not defining PATH_MAX by using xstrprintf
> > followed by a cleanup.
>
> As noticed by Thomas, he's right that we are introducing extra
> quoting of the command's argument, and I don't think we should be
> doing that in this patch. We can discuss the need to do so, but
> it should be done separately.
>
> Other than that, the patch looks good to me. Just give it a few more
> days (say until Monday) before we commit the patch. Do you have an
> FSF copyright assignment on file?
Not yet, I'll send a filled-in form in a few days.
next prev parent reply other threads:[~2013-05-29 12:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 16:36 Svante Signell
2013-05-23 17:08 ` Tom Tromey
2013-05-23 17:21 ` Svante Signell
2013-05-23 17:27 ` Tom Tromey
2013-05-23 17:54 ` Svante Signell
2013-05-24 3:01 ` Sergio Durigan Junior
2013-05-24 2:59 ` Sergio Durigan Junior
2013-05-24 4:27 ` Joel Brobecker
2013-05-24 8:53 ` Pedro Alves
2013-05-24 9:07 ` Svante Signell
2013-05-24 9:13 ` Sergio Durigan Junior
2013-05-27 11:41 ` Svante Signell
2013-05-27 12:10 ` Joel Brobecker
2013-05-27 12:21 ` Svante Signell
2013-05-27 13:48 ` Svante Signell
2013-05-27 13:57 ` Svante Signell
2013-05-27 14:31 ` Joel Brobecker
2013-05-27 15:59 ` Svante Signell
2013-05-29 9:26 ` Joel Brobecker
2013-05-29 12:18 ` Svante Signell [this message]
2013-05-27 16:03 ` New patch: " Svante Signell
2013-05-29 9:42 ` Joel Brobecker
2013-05-29 12:49 ` Svante Signell
2013-05-27 14:55 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369829899.30815.0.camel@G3620.my.own.domain \
--to=svante.signell@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox