From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18183 invoked by alias); 29 May 2013 12:18:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18162 invoked by uid 89); 29 May 2013 12:18:10 -0000 X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-la0-f46.google.com (HELO mail-la0-f46.google.com) (209.85.215.46) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 29 May 2013 12:18:09 +0000 Received: by mail-la0-f46.google.com with SMTP id er20so8587699lab.19 for ; Wed, 29 May 2013 05:18:07 -0700 (PDT) X-Received: by 10.112.19.9 with SMTP id a9mr1442490lbe.80.1369829887254; Wed, 29 May 2013 05:18:07 -0700 (PDT) Received: from [192.168.1.12] (178-78-231-178.customers.ownit.se. [178.78.231.178]) by mx.google.com with ESMTPSA id v4sm12053089lag.8.2013.05.29.05.18.06 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Wed, 29 May 2013 05:18:06 -0700 (PDT) Message-ID: <1369829899.30815.0.camel@G3620.my.own.domain> Subject: Re: Small patch to enable build of gdb-7.6 for GNU/Hurd From: Svante Signell Reply-To: svante.signell@gmail.com To: Joel Brobecker Cc: Sergio Durigan Junior , Pedro Alves , gdb-patches@sourceware.org Date: Wed, 29 May 2013 12:18:00 -0000 In-Reply-To: <20130529092606.GD5751@adacore.com> References: <519F2A7A.4050002@redhat.com> <1369386446.8127.51.camel@s1499.it.kth.se> <1369654913.8127.84.camel@s1499.it.kth.se> <20130527121028.GB5751@adacore.com> <1369657278.8127.90.camel@s1499.it.kth.se> <1369662500.8127.97.camel@s1499.it.kth.se> <1369663027.8127.99.camel@s1499.it.kth.se> <20130527143053.GC5751@adacore.com> <1369670373.8127.116.camel@s1499.it.kth.se> <20130529092606.GD5751@adacore.com> Content-Type: text/plain; charset="ISO-8859-15" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00994.txt.bz2 On Wed, 2013-05-29 at 13:26 +0400, Joel Brobecker wrote: > > 2013-05-27 Svante Signell > > > > * nto-tdep.c (nto_init_solib_absolute_prefix): Solve build > > problems for systems not defining PATH_MAX by using xstrprintf > > followed by a cleanup. > > As noticed by Thomas, he's right that we are introducing extra > quoting of the command's argument, and I don't think we should be > doing that in this patch. We can discuss the need to do so, but > it should be done separately. > > Other than that, the patch looks good to me. Just give it a few more > days (say until Monday) before we commit the patch. Do you have an > FSF copyright assignment on file? Not yet, I'll send a filled-in form in a few days.