From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
andrew.burgess@embecosm.com, fche@redhat.com,
jakub@redhat.com
Subject: Re: [PATCH] Adjust i386 registers on SystemTap probes' arguments (PR breakpoints/24541)
Date: Fri, 28 Jun 2019 20:33:00 -0000 [thread overview]
Message-ID: <87mui1laao.fsf@redhat.com> (raw)
In-Reply-To: <87ftntzpbk.fsf@tromey.com> (Tom Tromey's message of "Fri, 28 Jun 2019 09:45:19 -0600")
On Friday, June 28 2019, Tom Tromey wrote:
>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> gdb/ChangeLog:
> Sergio> 2019-06-27 Sergio Durigan Junior <sergiodj@redhat.com>
>
> Sergio> * gdbarch.c: Regenerate.
> Sergio> * gdbarch.h: Regenerate.
> Sergio> * gdbarch.sh: Add 'stap_adjust_register'.
> Sergio> * i386-tdep.c: Include '<unordered_set>'.
> Sergio> (i386_stap_adjust_register): New function.
> Sergio> (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
> Sergio> * stap-probe.c (stap_parse_register_operand): Call
> Sergio> 'gdbarch_stap_adjust_register'.
>
> Thank you for the patch and the excellent explanation.
>
> This is ok.
Thank you, Tom.
> For a while I was updating some SystemTap wiki page to link to these
> kinds of bugs, so that anybody else interested in supporting these
> probes had a list of oddities to work from. This one would seem to
> qualify for that.
Good point. I will edit
https://sourceware.org/systemtap/wiki/UserSpaceProbeImplementation and
include this bug for reference.
Pushed: 7d7571f0c14b4673ca95f6dc31d6f07d429e6697
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2019-06-28 20:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 22:00 Sergio Durigan Junior
2019-06-26 22:03 ` Sergio Durigan Junior
2019-06-28 15:45 ` Tom Tromey
2019-06-28 20:33 ` Sergio Durigan Junior [this message]
2019-06-29 14:58 ` Andrew Burgess
2019-07-02 15:21 ` [PATCH] gdb: Remove a non-const reference parameter Andrew Burgess
2019-07-02 15:35 ` Simon Marchi
2019-07-02 17:55 ` Tom Tromey
2019-07-02 16:40 ` Sergio Durigan Junior
2019-07-02 17:55 ` Tom Tromey
2019-07-17 15:32 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mui1laao.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=fche@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jakub@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox