From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12762 invoked by alias); 28 Jun 2019 20:33:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12738 invoked by uid 89); 28 Jun 2019 20:33:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=237A, 7628, D0EB, 0287 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Jun 2019 20:33:36 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9737031628EF; Fri, 28 Jun 2019 20:33:35 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C5871001B1A; Fri, 28 Jun 2019 20:33:35 +0000 (UTC) From: Sergio Durigan Junior To: Tom Tromey Cc: GDB Patches , andrew.burgess@embecosm.com, fche@redhat.com, jakub@redhat.com Subject: Re: [PATCH] Adjust i386 registers on SystemTap probes' arguments (PR breakpoints/24541) References: <20190626220031.6302-1-sergiodj@redhat.com> <87ftntzpbk.fsf@tromey.com> Date: Fri, 28 Jun 2019 20:33:00 -0000 In-Reply-To: <87ftntzpbk.fsf@tromey.com> (Tom Tromey's message of "Fri, 28 Jun 2019 09:45:19 -0600") Message-ID: <87mui1laao.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00640.txt.bz2 On Friday, June 28 2019, Tom Tromey wrote: >>>>>> "Sergio" == Sergio Durigan Junior writes: > > Sergio> gdb/ChangeLog: > Sergio> 2019-06-27 Sergio Durigan Junior > > Sergio> * gdbarch.c: Regenerate. > Sergio> * gdbarch.h: Regenerate. > Sergio> * gdbarch.sh: Add 'stap_adjust_register'. > Sergio> * i386-tdep.c: Include ''. > Sergio> (i386_stap_adjust_register): New function. > Sergio> (i386_elf_init_abi): Register 'i386_stap_adjust_register'. > Sergio> * stap-probe.c (stap_parse_register_operand): Call > Sergio> 'gdbarch_stap_adjust_register'. > > Thank you for the patch and the excellent explanation. > > This is ok. Thank you, Tom. > For a while I was updating some SystemTap wiki page to link to these > kinds of bugs, so that anybody else interested in supporting these > probes had a list of oddities to work from. This one would seem to > qualify for that. Good point. I will edit https://sourceware.org/systemtap/wiki/UserSpaceProbeImplementation and include this bug for reference. Pushed: 7d7571f0c14b4673ca95f6dc31d6f07d429e6697 Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/