Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Cc: Sergio Durigan Junior <sergiodj@redhat.com>,
	Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH] gdb: Remove a non-const reference parameter
Date: Tue, 02 Jul 2019 15:35:00 -0000	[thread overview]
Message-ID: <b964f2fd-495e-23cc-b7db-2eb75933a589@simark.ca> (raw)
In-Reply-To: <20190702152119.31612-1-andrew.burgess@embecosm.com>

On 2019-07-02 11:21 a.m., Andrew Burgess wrote:
> Non-const reference parameter should be avoided according to the GDB
> coding standard:
> 
>   https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Avoid_non-const_reference_parameters.2C_use_pointers_instead
> 
> This commit updates the gdbarch method gdbarch_stap_adjust_register,
> and the one implementation i386_stap_adjust_register to avoid using a
> non-const reference parameter.
> 
> I've also removed the kfail from the testsuite for bug 24541, as this
> issue is now resolved.

Hi Andrew,

So I was the one who added this rule to the guide.  When I asked for opinions and
didn't get any, I thought it was because it wasn't very controversial and chose to add it.

Since then, Pedro mentioned a few times he didn't agree with it.

I'd like to know what others think, should we keep it (and enforce it) or remove it?

Simon


  reply	other threads:[~2019-07-02 15:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26 22:00 [PATCH] Adjust i386 registers on SystemTap probes' arguments (PR breakpoints/24541) Sergio Durigan Junior
2019-06-26 22:03 ` Sergio Durigan Junior
2019-06-28 15:45 ` Tom Tromey
2019-06-28 20:33   ` Sergio Durigan Junior
2019-06-29 14:58 ` Andrew Burgess
2019-07-02 15:21   ` [PATCH] gdb: Remove a non-const reference parameter Andrew Burgess
2019-07-02 15:35     ` Simon Marchi [this message]
2019-07-02 17:55       ` Tom Tromey
2019-07-02 16:40     ` Sergio Durigan Junior
2019-07-02 17:55     ` Tom Tromey
2019-07-17 15:32     ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b964f2fd-495e-23cc-b7db-2eb75933a589@simark.ca \
    --to=simark@simark.ca \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox