Re: [PATCH 7/7] gdb, gdbserver: create the dependency directories from the Makefiles

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:

Simon> Note that this changes the command to create directories from "$(SHELL)
Simon> $(srcdir)/../install-sh -d" to "mkdir -p".  If there is a reason to use
Simon> install-sh to create directories in the build directory, I think it
Simon> should be documented, otherwise it just looks strange.

In the old days, 'mkdir -p' wasn't portable.  That's why mkinstalldirs
existed.  Not sure why this code used install-sh.

I don't know if 'mkdir -p' can be used today, though I tend to assume it
can; and anyway it's easy to switch to mkinstalldirs if need be.

Simon> @@ -2413,11 +2408,8 @@ clean mostlyclean: $(CONFIG_CLEAN)
Simon>  	rm -f gdb$(EXEEXT) core make.log
Simon>  	rm -f gdb[0-9]$(EXEEXT)
Simon>  	rm -f xml-builtin.c stamp-xml
Simon> -	rm -f $(DEPDIR)/*
Simon> -	for i in $(CONFIG_SRC_SUBDIR); do \
Simon> -		rm -f $$i/*.o;	\
Simon> -		rm -f $$i/$(DEPDIR)/*; \
Simon> -	done
Simon> +	rm -f $(addsuffix /*,$(ALL_DEPDIRS))
Simon> +	rm -f $(addsuffix /*.o,$(CONFIG_SRC_SUBDIR))
 
Simon>  # This used to depend on c-exp.c m2-exp.c TAGS
Simon>  # I believe this is wrong; the makefile standards for distclean just
Simon> @@ -2431,10 +2423,7 @@ distclean: clean
Simon>  	rm -f config.log config.cache
Simon>  	rm -f config.lt libtool
Simon>  	rm -f Makefile
Simon> -	rm -rf $(DEPDIR)
Simon> -	for i in $(CONFIG_SRC_SUBDIR); do \
Simon> -		if test -d $$i/$(DEPDIR); then rmdir $$i/$(DEPDIR); fi \
Simon> -	done
Simon> +	rm -rf $(ALL_DEPDIRS)

I don't think it should be necessary to update both 'clean' and
'distclean'.  The latter should depend on the former.

The old rule was "if configure made it, distclean removes it; if make
made it, clean removes it".  So I think the distclean change should be
dropped.

I'm unsure if this rule was ever really was discussed outside the
Automake list back in ancient times, I think François Pinard came up
with it.

Tom