From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 3/7] gdbserver: fix missing dependency tracking for gdbreplay.o
Date: Mon, 31 Aug 2026 14:51:42 -0400 [thread overview]
Message-ID: <20260831185300.572297-4-simon.marchi@efficios.com> (raw)
In-Reply-To: <20260831185300.572297-1-simon.marchi@efficios.com>
The rule for gdbreplay.o uses $(COMPILE.post), which makes the
compiler write the dependencies to $(DEPDIR)/gdbreplay.Tpo, but it does
not run $(POSTCOMPILE), which is what renames the .Tpo file to .Po.
After building gdbreplay, we are left with:
$ make gdbreplay
CXX gdbreplay.o
CXX utils.o
GEN version-generated.cc
CXX version.o
CXXLD gdbreplay /0.1s
$ ls -1 .deps
gdbreplay.Tpo
utils.Po
version.Po
This means that a change in a header file included by gdbreplay.cc will
not cause a rebuild.
Add the missing $(POSTCOMPILE) invocation.
Change-Id: Iea5ca939cf30a0fe892ed3d2c224d22f227f0272
---
gdbserver/Makefile.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in
index b06e0b86e45b..3a3c8e62d14f 100644
--- a/gdbserver/Makefile.in
+++ b/gdbserver/Makefile.in
@@ -592,6 +592,7 @@ target/%.o: ../gdb/target/%.c
gdbreplay.o: gdbreplay.cc
$(ECHO_CXX) $(COMPILE.pre) $(INTERNAL_CFLAGS) $(CXXFLAGS) \
-include gdbsupport/common-defs.h $(COMPILE.post) $<
+ $(POSTCOMPILE)
#
# Dependency tracking.
--
2.55.0
next prev parent reply other threads:[~2026-08-31 18:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 18:51 [PATCH 0/7] Some Makefile cleanups Simon Marchi
2026-08-31 18:51 ` [PATCH 1/7] gdb: update README about the GNU make requirement Simon Marchi
2026-09-01 12:26 ` Eli Zaretskii
2026-09-01 13:36 ` Simon Marchi
2026-08-31 18:51 ` [PATCH 2/7] gdb, gdbserver: require gcc-style dependency generation, drop the depcomp fallback Simon Marchi
2026-09-01 16:32 ` Tom Tromey
2026-09-01 20:16 ` Simon Marchi
2026-09-02 7:37 ` Rainer Orth
2026-09-02 12:26 ` Simon Marchi
2026-08-31 18:51 ` Simon Marchi [this message]
2026-09-01 16:33 ` [PATCH 3/7] gdbserver: fix missing dependency tracking for gdbreplay.o Tom Tromey
2026-08-31 18:51 ` [PATCH 4/7] gdb, gdbserver: always use order-only prerequisites for generated files Simon Marchi
2026-09-01 16:34 ` Tom Tromey
2026-08-31 18:51 ` [PATCH 5/7] gdb, gdbserver: remove the .NOEXPORT target Simon Marchi
2026-09-01 16:37 ` Tom Tromey
2026-08-31 18:51 ` [PATCH 6/7] gdb: remove the explicit ada-exp.o rule Simon Marchi
2026-09-01 16:38 ` Tom Tromey
2026-08-31 18:51 ` [PATCH 7/7] gdb, gdbserver: create the dependency directories from the Makefiles Simon Marchi
2026-09-01 16:47 ` Tom Tromey
2026-09-01 20:18 ` Simon Marchi
2026-09-01 20:37 ` Simon Marchi
2026-09-02 18:36 ` Tom Tromey
2026-09-03 13:45 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831185300.572297-4-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox