From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bmFSMs0Bl2q2ZBsAWB0awg (envelope-from ) for ; Tue, 01 Sep 2026 12:48:13 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ZrAeB1Vh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B7D241E033; Tue, 01 Sep 2026 12:48:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E7D651E033 for ; Tue, 01 Sep 2026 12:48:12 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 64DF14BA2E29 for ; Tue, 1 Sep 2026 16:48:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 64DF14BA2E29 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ZrAeB1Vh Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 7C1C74BA5433 for ; Tue, 1 Sep 2026 16:47:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C1C74BA5433 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7C1C74BA5433 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788281268; cv=none; b=aJaeoEtxZZH1wdeliTCBDyd1DYWSOIVNpmidY6lDzDw9eIir3cNpxIdWF1Lk5GszHQ+GX4b2b50QsMU1sZGDomX4ts4XMuHnoSkIMMcOSZi5nfqU7tP9tBaiHdO4tolbHQUmMvmnMJBp4a2eoUscxcH+et2dWXqXrUrs0fE0qM8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788281268; c=relaxed/simple; bh=uHRcE+aUO0tWWrpRqsBd5wrOHodStgVroqXNubzwY9o=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=E2RTrK/K6kYDSfUnvh1DGN52stspvIAw0ByFIxqQI4RSlvKRGy7/58qKhp2mm3SXqdx+dyIy7cDG20h1ErS7F1T1tvYHEC2SfmpgQApLoy0R3ZQRxh7h2yjh5Jx9p1hd20h6M/00+rgAPZpOL5DAqX3riF5XJW6YqmbmQYRCcRw= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ZrAeB1Vh reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C1C74BA5433 Received: from eig-obgw-6007b.ext.cloudfilter.net ([10.0.30.166]) by cmsmtp with ESMTPS id 1HXRxWV9cJFmF1ReGxyBvE; Tue, 01 Sep 2026 16:47:48 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 1ReFxkXW3F2DA1ReFxR8wt; Tue, 01 Sep 2026 16:47:47 +0000 X-Authority-Analysis: v=2.4 cv=FaM3xI+6 c=1 sm=1 tr=0 ts=6a9701b3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=GS708vnfqSc_tey8gqMA:9 a=QEXdDO2ut3YA:10 a=jhqOcbufqs7Y1TYCrUUU:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rt5gbjpN4cMfmmdCK9pzNdLCEaOkf8ggkxAKI9C4MI8=; b=ZrAeB1VhETc9o3VE6D7jsq9F2+ yBavJ6/fh1NuX2EB7ZTdOqM+I3nHMQ5jClN/VinOhPXB6ML9AMQcC2P4t8gEpBCOuT5ixXImq4+Dn ezZa89DKX6ZE+9ZRSRIrFBY+r; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:53048 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1x1ReE-0000000378Q-3oVJ; Tue, 01 Sep 2026 10:47:46 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 7/7] gdb, gdbserver: create the dependency directories from the Makefiles In-Reply-To: <20260831185300.572297-8-simon.marchi@efficios.com> (Simon Marchi's message of "Mon, 31 Aug 2026 14:51:46 -0400") References: <20260831185300.572297-1-simon.marchi@efficios.com> <20260831185300.572297-8-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 01 Sep 2026 10:47:45 -0600 Message-ID: <87mru07wb2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1x1ReE-0000000378Q-3oVJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:53048 X-Source-Auth: tom+tromey.com X-Email-Count: 20 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNow7Gtjo2czdxp4unb3ytZ2FQ+1gZTFJA1MnDDr8PysausjEB8WNXoyWkcTPn/3n8ceZ+6gqf6NeWvFWLXgmyLAb2thxS+8IQJKxSOPUQsSqiw46Rh1 Xxbnxk0NaSCvwFnONT5IcG+8cL5KRB514J0pA0N2ekTAKLFv8dyAYywn9J4+YnL68Q/rE7FQUfmVWxRyUD7NQhZZSq9NWYrojt0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" =3D=3D Simon Marchi writes: Simon> Note that this changes the command to create directories from "$(SHE= LL) Simon> $(srcdir)/../install-sh -d" to "mkdir -p". If there is a reason to = use Simon> install-sh to create directories in the build directory, I think it Simon> should be documented, otherwise it just looks strange. In the old days, 'mkdir -p' wasn't portable. That's why mkinstalldirs existed. Not sure why this code used install-sh. I don't know if 'mkdir -p' can be used today, though I tend to assume it can; and anyway it's easy to switch to mkinstalldirs if need be. Simon> @@ -2413,11 +2408,8 @@ clean mostlyclean: $(CONFIG_CLEAN) Simon> rm -f gdb$(EXEEXT) core make.log Simon> rm -f gdb[0-9]$(EXEEXT) Simon> rm -f xml-builtin.c stamp-xml Simon> - rm -f $(DEPDIR)/* Simon> - for i in $(CONFIG_SRC_SUBDIR); do \ Simon> - rm -f $$i/*.o; \ Simon> - rm -f $$i/$(DEPDIR)/*; \ Simon> - done Simon> + rm -f $(addsuffix /*,$(ALL_DEPDIRS)) Simon> + rm -f $(addsuffix /*.o,$(CONFIG_SRC_SUBDIR)) =20 Simon> # This used to depend on c-exp.c m2-exp.c TAGS Simon> # I believe this is wrong; the makefile standards for distclean just Simon> @@ -2431,10 +2423,7 @@ distclean: clean Simon> rm -f config.log config.cache Simon> rm -f config.lt libtool Simon> rm -f Makefile Simon> - rm -rf $(DEPDIR) Simon> - for i in $(CONFIG_SRC_SUBDIR); do \ Simon> - if test -d $$i/$(DEPDIR); then rmdir $$i/$(DEPDIR); fi \ Simon> - done Simon> + rm -rf $(ALL_DEPDIRS) I don't think it should be necessary to update both 'clean' and 'distclean'. The latter should depend on the former. The old rule was "if configure made it, distclean removes it; if make made it, clean removes it". So I think the distclean change should be dropped. I'm unsure if this rule was ever really was discussed outside the Automake list back in ancient times, I think Fran=C3=A7ois Pinard came up with it. Tom