From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>, <vladimir@codesourcery.com>
Subject: Re: [PATCH 3/6] attach to command_option-changed observer.
Date: Thu, 26 Jul 2012 13:59:00 -0000 [thread overview]
Message-ID: <87lii6fwsq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <2744162.LCmhzUq8J1@qiyao.dyndns.org> (Yao Qi's message of "Thu, 26 Jul 2012 20:46:59 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Tom> That would be one way to deal with the problem, but there are probably
Tom> other ways as well. (I didn't commit that patch because Volodya had a
Tom> different approach to emitting the notifications that I was interested
Tom> in... but I still think it is a decent idea.)
Yao> What is the different approach? I don't see any discussion in that
Yao> thread.
That patch was preparation for emitting better breakpoint notifications
-- which Vladimir implemented in a different way.
You can see what he did in mi-interp.c:mi_breakpoint_created.
Yao> What should we do here? Shall we keep using ui-file (as what I
Yao> wrote in this patch) or migrate to ui-out with your patch applied?
I think you should take whichever approach you think is best.
The most important thing is to not have the quoting bug.
Tom
next prev parent reply other threads:[~2012-07-26 13:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 16:11 [RFC 0/6] MI notification of command option change Yao Qi
2012-07-24 16:11 ` [PATCH 2/6] allow to suppress more mi notification Yao Qi
2012-07-24 20:40 ` Tom Tromey
2012-07-26 15:30 ` Pedro Alves
2012-07-27 2:57 ` Yao Qi
2012-07-27 13:27 ` Pedro Alves
2012-07-24 16:11 ` [PATCH 4/6] new add_setshow_enum_cmd_with_notif and scheduler-locking Yao Qi
2012-07-24 20:50 ` Tom Tromey
2012-07-26 15:41 ` Pedro Alves
2012-07-24 16:11 ` [PATCH 6/6] new add_setshow_string_cmd_with_notif and trace-notes Yao Qi
2012-07-24 20:54 ` Tom Tromey
2012-07-24 16:11 ` [PATCH 3/6] attach to command_option-changed observer Yao Qi
2012-07-24 17:10 ` Eli Zaretskii
2012-07-24 20:47 ` Tom Tromey
2012-07-26 12:47 ` Yao Qi
2012-07-26 13:59 ` Tom Tromey [this message]
2012-07-26 15:31 ` Pedro Alves
2012-07-24 16:11 ` [PATCH 1/6] new observer command_option_changed Yao Qi
2012-07-24 20:39 ` Tom Tromey
2012-07-25 3:56 ` Yao Qi
2012-07-25 14:44 ` Tom Tromey
2012-07-26 15:21 ` Pedro Alves
2012-07-25 14:32 ` Tom Tromey
2012-07-26 8:55 ` Yao Qi
2012-07-24 16:12 ` [PATCH 5/6] new add_setshow_boolean_cmd_with_notify and circular-trace-buffer Yao Qi
2012-07-24 20:53 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lii6fwsq.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=vladimir@codesourcery.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox