Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Cc: Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 2/6] allow to suppress more mi notification
Date: Fri, 27 Jul 2012 02:57:00 -0000	[thread overview]
Message-ID: <1705340.40y1UybpUm@qiyao.dyndns.org> (raw)
In-Reply-To: <5011628A.3000707@redhat.com>

On Thursday, July 26, 2012 04:30:18 PM Pedro Alves wrote:
> > -extern int mi_suppress_breakpoint_notifications;
> > +
> > +enum MI_SUPRESS_NOTIFICATION { MI_SUPPRESS_BREAKPOINT };
> > +extern int mi_suppress_notification[];
> >
> >  
> 
> Quite frankly, I don't see how putting these in an array is better than
> a separate global for each.  The memory used is the same, and with separate
> globals, it's a little easier to debug from a top gdb (just print
> mi_suppress_<TAB> to see the list of possibilities, etc.)  Are you planning
> on doing something over the whole array, that is abstracted from the
> semantics of each element of the array?

The intention of this change is to avoid introducing more global variables to 
suppress different types of notification.  I plan to add more notifications 
here (for register change, memory change, trace experiment change, etc), and 
we need more suppress flags for them.  Array makes sense here.

AFAICS, I don't do something over the whole array.

-- 
Yao (齐尧)


  reply	other threads:[~2012-07-27  2:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-24 16:11 [RFC 0/6] MI notification of command option change Yao Qi
2012-07-24 16:11 ` [PATCH 2/6] allow to suppress more mi notification Yao Qi
2012-07-24 20:40   ` Tom Tromey
2012-07-26 15:30   ` Pedro Alves
2012-07-27  2:57     ` Yao Qi [this message]
2012-07-27 13:27       ` Pedro Alves
2012-07-24 16:11 ` [PATCH 4/6] new add_setshow_enum_cmd_with_notif and scheduler-locking Yao Qi
2012-07-24 20:50   ` Tom Tromey
2012-07-26 15:41     ` Pedro Alves
2012-07-24 16:11 ` [PATCH 3/6] attach to command_option-changed observer Yao Qi
2012-07-24 17:10   ` Eli Zaretskii
2012-07-24 20:47   ` Tom Tromey
2012-07-26 12:47     ` Yao Qi
2012-07-26 13:59       ` Tom Tromey
2012-07-26 15:31   ` Pedro Alves
2012-07-24 16:11 ` [PATCH 6/6] new add_setshow_string_cmd_with_notif and trace-notes Yao Qi
2012-07-24 20:54   ` Tom Tromey
2012-07-24 16:11 ` [PATCH 1/6] new observer command_option_changed Yao Qi
2012-07-24 20:39   ` Tom Tromey
2012-07-25  3:56     ` Yao Qi
2012-07-25 14:44       ` Tom Tromey
2012-07-26 15:21         ` Pedro Alves
2012-07-25 14:32   ` Tom Tromey
2012-07-26  8:55     ` Yao Qi
2012-07-24 16:12 ` [PATCH 5/6] new add_setshow_boolean_cmd_with_notify and circular-trace-buffer Yao Qi
2012-07-24 20:53   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1705340.40y1UybpUm@qiyao.dyndns.org \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox