From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH 1/6] new observer command_option_changed.
Date: Thu, 26 Jul 2012 08:55:00 -0000 [thread overview]
Message-ID: <3014587.ycr7yI3D0I@qiyao.dyndns.org> (raw)
In-Reply-To: <87lii7lxno.fsf@fleche.redhat.com>
On Wednesday, July 25, 2012 08:31:55 AM Tom Tromey wrote:
> Yao> + if (c->notify_observer_p)
> Yao> + observer_notify_command_option_changed (c->name, arg);
>
> Last night I realized that this does the wrong thing for multi-word
> parameters. E.g., for "set print elements", the MI client will just see
> "elements".
Right, we are unable to get the previous command instance "print" in command
instance "elements". So we have to move
'observer_notify_command_option_changed' out of do_setshow_command to its
caller, top.c:execute_command, where the full command option and value is
available. Then, we can change 'do_setshow_command' to return a boolean value
indicating option is changed or not, and call
observer_notify_command_option_changed if do_setshow_command returns true.
It works fine for me now. I'll post a patch.
--
Yao (齐尧)
next prev parent reply other threads:[~2012-07-26 8:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 16:11 [RFC 0/6] MI notification of command option change Yao Qi
2012-07-24 16:11 ` [PATCH 3/6] attach to command_option-changed observer Yao Qi
2012-07-24 17:10 ` Eli Zaretskii
2012-07-24 20:47 ` Tom Tromey
2012-07-26 12:47 ` Yao Qi
2012-07-26 13:59 ` Tom Tromey
2012-07-26 15:31 ` Pedro Alves
2012-07-24 16:11 ` [PATCH 6/6] new add_setshow_string_cmd_with_notif and trace-notes Yao Qi
2012-07-24 20:54 ` Tom Tromey
2012-07-24 16:11 ` [PATCH 1/6] new observer command_option_changed Yao Qi
2012-07-24 20:39 ` Tom Tromey
2012-07-25 3:56 ` Yao Qi
2012-07-25 14:44 ` Tom Tromey
2012-07-26 15:21 ` Pedro Alves
2012-07-25 14:32 ` Tom Tromey
2012-07-26 8:55 ` Yao Qi [this message]
2012-07-24 16:11 ` [PATCH 2/6] allow to suppress more mi notification Yao Qi
2012-07-24 20:40 ` Tom Tromey
2012-07-26 15:30 ` Pedro Alves
2012-07-27 2:57 ` Yao Qi
2012-07-27 13:27 ` Pedro Alves
2012-07-24 16:11 ` [PATCH 4/6] new add_setshow_enum_cmd_with_notif and scheduler-locking Yao Qi
2012-07-24 20:50 ` Tom Tromey
2012-07-26 15:41 ` Pedro Alves
2012-07-24 16:12 ` [PATCH 5/6] new add_setshow_boolean_cmd_with_notify and circular-trace-buffer Yao Qi
2012-07-24 20:53 ` Tom Tromey
2012-07-27 15:23 [RCF 0/6 V2] MI notification of command option change Yao Qi
2012-07-27 15:23 ` [PATCH 1/6] new observer command_option_changed Yao Qi
2012-07-27 17:56 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3014587.ycr7yI3D0I@qiyao.dyndns.org \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox