Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
	 nd <nd@arm.com>
Subject: Re: [PATCH 2/4] testsuite: Add option to capture GDB debug
Date: Thu, 25 Apr 2019 14:31:00 -0000	[thread overview]
Message-ID: <87lfzycg1x.fsf@tromey.com> (raw)
In-Reply-To: <20190423130624.94781-3-alan.hayward@arm.com> (Alan Hayward's	message of "Tue, 23 Apr 2019 13:06:31 +0000")

>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:

Alan> @@ -1716,6 +1716,8 @@ proc default_gdb_start { } {
Alan>  	    warning "Couldn't set the width to 0."
Alan>  	}
Alan>      }
Alan> +
Alan> +    gdb_debug_init

One question I have is how this interacts with tests that run gdb
multiple times.  Is there just one log?

Alan> +    if ![info exists gdbdebug] {

I think it's preferable to brace expressions, like "if {![info exists...]}".
I guess it's just stylistic though.

Alan> +  # First ensure logging is off.
Alan> +  gdb_test_no_output "set logging off"

Related to the multiple gdb invocations question -- I think this will
result in duplicate test names, so something extra should probably be
done here.

thanks,
Tom


  parent reply	other threads:[~2019-04-25 14:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190423130624.94781-1-alan.hayward@arm.com>
2019-04-23 13:06 ` [PATCH 4/4] testsuite: Add option to capture gdbserver debug Alan Hayward
2019-04-25 14:39   ` Tom Tromey
     [not found] ` <20190423130624.94781-2-alan.hayward@arm.com>
2019-04-25 14:27   ` [PATCH 1/4] Add debug redirect option Tom Tromey
     [not found] ` <20190423130624.94781-3-alan.hayward@arm.com>
2019-04-25 14:31   ` Tom Tromey [this message]
2019-04-25 15:13     ` [PATCH 2/4] testsuite: Add option to capture GDB debug Alan Hayward
     [not found] ` <20190423130624.94781-4-alan.hayward@arm.com>
2019-04-25 14:36   ` [PATCH 3/4] testsuite: Disable tests when logging Tom Tromey
2019-04-25 14:41 ` [PATCH 0/4] Capture GDB debug when running the testsuite Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfzycg1x.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=Alan.Hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox