From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74227 invoked by alias); 25 Apr 2019 14:31:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74217 invoked by uid 89); 25 Apr 2019 14:31:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=Couldnt, Couldn't X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.80) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Apr 2019 14:31:25 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway31.websitewelcome.com (Postfix) with ESMTP id BE70474A17 for ; Thu, 25 Apr 2019 09:31:23 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id JfPHhYHC5YTGMJfPHheAaa; Thu, 25 Apr 2019 09:31:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nyVZJxk/Fx/PIsudaB54zACfFVp3euiNfjwG9W4Ugx4=; b=rl6bRdcfw2YkLKAd3Ef4EYQgd/ JeNBnS31b5tmp9FLWdKQ8fwHFVPscoUYXrW/Cv//J/Nv0w4ZUN67sfYqeaw41Udh4XUkYRNyYJqMY gVfIxzgVHmaFlexhNj3y2bqlZ; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:56306 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hJfPH-000Q4V-HT; Thu, 25 Apr 2019 09:31:23 -0500 From: Tom Tromey To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH 2/4] testsuite: Add option to capture GDB debug References: <20190423130624.94781-1-alan.hayward@arm.com> <20190423130624.94781-3-alan.hayward@arm.com> Date: Thu, 25 Apr 2019 14:31:00 -0000 In-Reply-To: <20190423130624.94781-3-alan.hayward@arm.com> (Alan Hayward's message of "Tue, 23 Apr 2019 13:06:31 +0000") Message-ID: <87lfzycg1x.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00519.txt.bz2 >>>>> "Alan" == Alan Hayward writes: Alan> @@ -1716,6 +1716,8 @@ proc default_gdb_start { } { Alan> warning "Couldn't set the width to 0." Alan> } Alan> } Alan> + Alan> + gdb_debug_init One question I have is how this interacts with tests that run gdb multiple times. Is there just one log? Alan> + if ![info exists gdbdebug] { I think it's preferable to brace expressions, like "if {![info exists...]}". I guess it's just stylistic though. Alan> + # First ensure logging is off. Alan> + gdb_test_no_output "set logging off" Related to the multiple gdb invocations question -- I think this will result in duplicate test names, so something extra should probably be done here. thanks, Tom