From: Tom Tromey <tom@tromey.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH 3/4] testsuite: Disable tests when logging
Date: Thu, 25 Apr 2019 14:36:00 -0000 [thread overview]
Message-ID: <87h8amcfso.fsf@tromey.com> (raw)
In-Reply-To: <20190423130624.94781-4-alan.hayward@arm.com> (Alan Hayward's message of "Tue, 23 Apr 2019 13:06:32 +0000")
>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:
Alan> * gdb.base/breakpoint-in-ro-region.exp: Disable when debugging.
[...]
My first reaction to this was negative, but after thinking about it a
little I came around. I think my view is that enabling debug logging
for the test suite is primarily a debugging tool, and so it's fine --
especially for tests that are already enabling debugging -- for it not
to work universally.
Alan> +# Do not run if gdb debug is enabled
Normally comments should have a "." at the end.
It would perhaps be good if the comments explained why.
Alan> +# Do not run if gdb debug is enabled - it interferes with the command history.
... like this one. Is that reasonable?
thanks,
Tom
next prev parent reply other threads:[~2019-04-25 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190423130624.94781-1-alan.hayward@arm.com>
2019-04-23 13:06 ` [PATCH 4/4] testsuite: Add option to capture gdbserver debug Alan Hayward
2019-04-25 14:39 ` Tom Tromey
[not found] ` <20190423130624.94781-2-alan.hayward@arm.com>
2019-04-25 14:27 ` [PATCH 1/4] Add debug redirect option Tom Tromey
[not found] ` <20190423130624.94781-3-alan.hayward@arm.com>
2019-04-25 14:31 ` [PATCH 2/4] testsuite: Add option to capture GDB debug Tom Tromey
2019-04-25 15:13 ` Alan Hayward
[not found] ` <20190423130624.94781-4-alan.hayward@arm.com>
2019-04-25 14:36 ` Tom Tromey [this message]
2019-04-25 14:41 ` [PATCH 0/4] Capture GDB debug when running the testsuite Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8amcfso.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox