From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108991 invoked by alias); 25 Apr 2019 14:36:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108982 invoked by uid 89); 25 Apr 2019 14:36:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.54.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Apr 2019 14:36:57 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 8FD11400DB573 for ; Thu, 25 Apr 2019 09:36:56 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id JfUeh0lYE4FKpJfUehSSTn; Thu, 25 Apr 2019 09:36:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SSjL5yRUPOEWvFm4YrvWjim2hwwag/jdqcH4uMFfSLk=; b=goUQ7/SGGHgeGTA81Kyytuweq+ P9DHpMZHW6rl7CnEEWbF3Zhe+Va4YOPOUtqZRyu3T6v8DQmT22aUkDSliHcUn7fxu4zL78jREZITx eBg6hz30kYnV6oPES6InZG08E; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:56346 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hJfUe-000RhS-BY; Thu, 25 Apr 2019 09:36:56 -0500 From: Tom Tromey To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH 3/4] testsuite: Disable tests when logging References: <20190423130624.94781-1-alan.hayward@arm.com> <20190423130624.94781-4-alan.hayward@arm.com> Date: Thu, 25 Apr 2019 14:36:00 -0000 In-Reply-To: <20190423130624.94781-4-alan.hayward@arm.com> (Alan Hayward's message of "Tue, 23 Apr 2019 13:06:32 +0000") Message-ID: <87h8amcfso.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00521.txt.bz2 >>>>> "Alan" == Alan Hayward writes: Alan> * gdb.base/breakpoint-in-ro-region.exp: Disable when debugging. [...] My first reaction to this was negative, but after thinking about it a little I came around. I think my view is that enabling debug logging for the test suite is primarily a debugging tool, and so it's fine -- especially for tests that are already enabling debugging -- for it not to work universally. Alan> +# Do not run if gdb debug is enabled Normally comments should have a "." at the end. It would perhaps be good if the comments explained why. Alan> +# Do not run if gdb debug is enabled - it interferes with the command history. ... like this one. Is that reasonable? thanks, Tom