From: Tom Tromey <tromey@redhat.com>
To: Siddhesh Poyarekar <siddhesh@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] bitpos: Minor python changes for bitpos expansion
Date: Fri, 10 Aug 2012 16:59:00 -0000 [thread overview]
Message-ID: <87k3x6adkf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120805005417.6e8d34d9@spoyarek> (Siddhesh Poyarekar's message of "Sun, 5 Aug 2012 00:54:17 +0530")
>>>>> "Siddhesh" == Siddhesh Poyarekar <siddhesh@redhat.com> writes:
Siddhesh> This is the final (and the smallest) patch in the bitpos expansion
Siddhesh> changes. This patch changes python-types code to use
Siddhesh> PyLong_FromLongLong for bitpos and type.length.
Siddhesh> - arg = PyLong_FromLong (TYPE_FIELD_BITPOS (type, field));
Siddhesh> + arg = PyLong_FromLongLong (TYPE_FIELD_BITPOS (type, field));
I think this patch should use gdb_py_long_from_longest in both spots.
See python-internal.h.
Other than that, this is fine.
I think it could go in any time, it doesn't seem dependent on the main
patch.
Tom
next prev parent reply other threads:[~2012-08-10 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 19:24 Siddhesh Poyarekar
2012-08-10 16:59 ` Tom Tromey [this message]
2012-08-10 18:58 ` Siddhesh Poyarekar
2012-08-10 20:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3x6adkf.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox