Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] bitpos: Minor python changes for bitpos expansion
Date: Fri, 10 Aug 2012 18:58:00 -0000	[thread overview]
Message-ID: <20120811002716.61ba0e75@spoyarek> (raw)
In-Reply-To: <87k3x6adkf.fsf@fleche.redhat.com>

On Fri, 10 Aug 2012 10:58:56 -0600, Tom wrote:
> I think this patch should use gdb_py_long_from_longest in both spots.
> See python-internal.h.
> 
> Other than that, this is fine.
> I think it could go in any time, it doesn't seem dependent on the main
> patch.
> 

Thanks, I've pushed the patch with the change you've asked for - sorry
about it too, since you had told me about that function in an earlier
change and I had managed to forget about it.

Regards,
Siddhesh


  reply	other threads:[~2012-08-10 18:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-04 19:24 Siddhesh Poyarekar
2012-08-10 16:59 ` Tom Tromey
2012-08-10 18:58   ` Siddhesh Poyarekar [this message]
2012-08-10 20:42     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120811002716.61ba0e75@spoyarek \
    --to=siddhesh@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox