From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8109 invoked by alias); 10 Aug 2012 18:58:08 -0000 Received: (qmail 8093 invoked by uid 22791); 10 Aug 2012 18:58:06 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Aug 2012 18:57:47 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7AIvkx6012423 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 10 Aug 2012 14:57:46 -0400 Received: from spoyarek (vpn-238-166.phx2.redhat.com [10.3.238.166]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7AIviWI016562; Fri, 10 Aug 2012 14:57:45 -0400 Date: Fri, 10 Aug 2012 18:58:00 -0000 From: Siddhesh Poyarekar To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] bitpos: Minor python changes for bitpos expansion Message-ID: <20120811002716.61ba0e75@spoyarek> In-Reply-To: <87k3x6adkf.fsf@fleche.redhat.com> References: <20120805005417.6e8d34d9@spoyarek> <87k3x6adkf.fsf@fleche.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00323.txt.bz2 On Fri, 10 Aug 2012 10:58:56 -0600, Tom wrote: > I think this patch should use gdb_py_long_from_longest in both spots. > See python-internal.h. > > Other than that, this is fine. > I think it could go in any time, it doesn't seem dependent on the main > patch. > Thanks, I've pushed the patch with the change you've asked for - sorry about it too, since you had told me about that function in an earlier change and I had managed to forget about it. Regards, Siddhesh