From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93691-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6217 invoked by alias); 10 Aug 2012 16:59:24 -0000
Received: (qmail 6208 invoked by uid 22791); 10 Aug 2012 16:59:20 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Aug 2012 16:58:58 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7AGwvvH021824	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 10 Aug 2012 12:58:58 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7AGwuVR000750	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 10 Aug 2012 12:58:57 -0400
From: Tom Tromey <tromey@redhat.com>
To: Siddhesh Poyarekar <siddhesh@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] bitpos: Minor python changes for bitpos expansion
References: <20120805005417.6e8d34d9@spoyarek>
Date: Fri, 10 Aug 2012 16:59:00 -0000
In-Reply-To: <20120805005417.6e8d34d9@spoyarek> (Siddhesh Poyarekar's message	of "Sun, 5 Aug 2012 00:54:17 +0530")
Message-ID: <87k3x6adkf.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00320.txt.bz2

>>>>> "Siddhesh" == Siddhesh Poyarekar <siddhesh@redhat.com> writes:

Siddhesh> This is the final (and the smallest) patch in the bitpos expansion
Siddhesh> changes. This patch changes python-types code to use
Siddhesh> PyLong_FromLongLong for bitpos and type.length.

Siddhesh> -	  arg = PyLong_FromLong (TYPE_FIELD_BITPOS (type, field));
Siddhesh> +	  arg = PyLong_FromLongLong (TYPE_FIELD_BITPOS (type, field));

I think this patch should use gdb_py_long_from_longest in both spots.
See python-internal.h.

Other than that, this is fine.
I think it could go in any time, it doesn't seem dependent on the main
patch.

Tom