From: Tom Tromey <tromey@redhat.com>
To: Alexey Makhalov <makhaloff@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Sim hangs on new target at dup_arg_p() in infinite loop.
Date: Fri, 20 Sep 2013 17:33:00 -0000 [thread overview]
Message-ID: <87k3ibqtxk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CALd+sge-JGnmCc3Sj1iExukM=J9n=QM2ZgUmBPZa9FKvJwyBfg@mail.gmail.com> (Alexey Makhalov's message of "Thu, 19 Sep 2013 22:02:20 -0700")
>>>>> "Alexey" == Alexey Makhalov <makhaloff@gmail.com> writes:
Alexey> + arg_table = htab_create (ARG_HASH_SIZE, htab_hash_string,
Alexey> + (int (*)(const void *, const void *)) streq, free);
I think casts like this are better avoided.
Since streq is only used here, it is no trouble to just give it the
proper type.
Alexey> + *slot = strdup(arg);
The GNU coding style requires a space before the paren here.
Tom
next prev parent reply other threads:[~2013-09-20 17:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 20:13 Alexey Makhalov
2013-09-11 22:28 ` Mike Frysinger
2013-09-17 18:11 ` Tom Tromey
[not found] ` <CALd+sgeSJz46ja1xbbFYO12kiF=LjVCaF2Xy_TzeMUkPkwZVmw@mail.gmail.com>
2013-09-20 5:02 ` Alexey Makhalov
2013-09-20 17:33 ` Tom Tromey [this message]
2013-09-21 2:59 ` Alexey Makhalov
2013-11-07 15:20 ` Tom Tromey
2013-11-08 7:25 ` Alexey Makhalov
2013-11-27 11:28 ` Mike Frysinger
2013-11-27 12:22 ` Joel Brobecker
2013-11-27 18:58 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3ibqtxk.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=makhaloff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox