From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-105632-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15430 invoked by alias); 20 Sep 2013 17:33:48 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 15384 invoked by uid 89); 20 Sep 2013 17:33:47 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Sep 2013 17:33:47 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8KHXjD5006363	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 20 Sep 2013 13:33:45 -0400
Received: from barimba (ovpn-113-63.phx2.redhat.com [10.3.113.63])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r8KHXhRC003598	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 20 Sep 2013 13:33:44 -0400
From: Tom Tromey <tromey@redhat.com>
To: Alexey Makhalov <makhaloff@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Sim hangs on new target at dup_arg_p() in infinite loop.
References: <CALd+sgcTRoRt94vXkWZ62xzb7q_mhfkuUXUFs3EwGdAs-1TQEg@mail.gmail.com>	<87bo3rz790.fsf@fleche.redhat.com>	<CALd+sgeSJz46ja1xbbFYO12kiF=LjVCaF2Xy_TzeMUkPkwZVmw@mail.gmail.com>	<CALd+sge-JGnmCc3Sj1iExukM=J9n=QM2ZgUmBPZa9FKvJwyBfg@mail.gmail.com>
Date: Fri, 20 Sep 2013 17:33:00 -0000
In-Reply-To: <CALd+sge-JGnmCc3Sj1iExukM=J9n=QM2ZgUmBPZa9FKvJwyBfg@mail.gmail.com>	(Alexey Makhalov's message of "Thu, 19 Sep 2013 22:02:20 -0700")
Message-ID: <87k3ibqtxk.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-09/txt/msg00777.txt.bz2

>>>>> "Alexey" == Alexey Makhalov <makhaloff@gmail.com> writes:

Alexey> +        arg_table = htab_create (ARG_HASH_SIZE, htab_hash_string,
Alexey> +               (int (*)(const void *, const void *)) streq, free);

I think casts like this are better avoided.
Since streq is only used here, it is no trouble to just give it the
proper type.

Alexey> +  *slot = strdup(arg);

The GNU coding style requires a space before the paren here.

Tom