From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Cc: Alexey Makhalov <makhaloff@gmail.com>
Subject: Re: Sim hangs on new target at dup_arg_p() in infinite loop.
Date: Wed, 11 Sep 2013 22:28:00 -0000 [thread overview]
Message-ID: <201309111828.35486.vapier@gentoo.org> (raw)
In-Reply-To: <CALd+sgcTRoRt94vXkWZ62xzb7q_mhfkuUXUFs3EwGdAs-1TQEg@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 828 bytes --]
On Monday 09 September 2013 16:13:38 Alexey Makhalov wrote:
> I've added checking for hash table overflow. It's better to have
> internal error message instead of looping.
please fix your mailer to send patches inline rather than base64 encoded. it
makes reviewing a lot easier when you do.
> --- sim/common/sim-options.c 3 Sep 2013 20:45:08 -0000 1.31
> +++ sim/common/sim-options.c 9 Sep 2013 20:12:25 -0000
>
> + if (table_is_full++) {
GNU style says the brace goes on the following line.
> + fprintf (stderr, "Internal error - number of options more than
%d\n",
use sim_io_eprintf instead of fprintf
> + ARG_HASH_SIZE);
> + abort ();
> + }
> + }
also, i'm pretty sure the indentation style in your change is incorrect.
please adjust to the GNU style.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-11 22:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 20:13 Alexey Makhalov
2013-09-11 22:28 ` Mike Frysinger [this message]
2013-09-17 18:11 ` Tom Tromey
[not found] ` <CALd+sgeSJz46ja1xbbFYO12kiF=LjVCaF2Xy_TzeMUkPkwZVmw@mail.gmail.com>
2013-09-20 5:02 ` Alexey Makhalov
2013-09-20 17:33 ` Tom Tromey
2013-09-21 2:59 ` Alexey Makhalov
2013-11-07 15:20 ` Tom Tromey
2013-11-08 7:25 ` Alexey Makhalov
2013-11-27 11:28 ` Mike Frysinger
2013-11-27 12:22 ` Joel Brobecker
2013-11-27 18:58 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309111828.35486.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=makhaloff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox