From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32337 invoked by alias); 11 Sep 2013 22:28:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32328 invoked by uid 89); 11 Sep 2013 22:28:34 -0000 Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 11 Sep 2013 22:28:34 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_THREADED autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 4CB1D33EB61; Wed, 11 Sep 2013 22:28:31 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: Sim hangs on new target at dup_arg_p() in infinite loop. Date: Wed, 11 Sep 2013 22:28:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.10.6; KDE/4.6.5; x86_64; ; ) Cc: Alexey Makhalov References: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1737757.o7N78zozgx"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201309111828.35486.vapier@gentoo.org> X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00363.txt.bz2 --nextPart1737757.o7N78zozgx Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 817 On Monday 09 September 2013 16:13:38 Alexey Makhalov wrote: > I've added checking for hash table overflow. It's better to have > internal error message instead of looping. please fix your mailer to send patches inline rather than base64 encoded. = it=20 makes reviewing a lot easier when you do. > --- sim/common/sim-options.c 3 Sep 2013 20:45:08 -0000 1.31 > +++ sim/common/sim-options.c 9 Sep 2013 20:12:25 -0000 > > + if (table_is_full++) { GNU style says the brace goes on the following line. > + fprintf (stderr, "Internal error - number of options more than= =20 %d\n", use sim_io_eprintf instead of fprintf > + ARG_HASH_SIZE); > + abort (); > + }=09 > + } also, i'm pretty sure the indentation style in your change is incorrect.=20= =20 please adjust to the GNU style. -mike --nextPart1737757.o7N78zozgx Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJSMO6TAAoJEEFjO5/oN/WBLLoQAMXFGGeX7HAyk9cNgQw8TXKm Vq89FefjoVb3ebsGobL+Sid9eBO29Z6dL8cs1zzmNyblCJiMCjkpOVWVh2AdUGXz bkcFbwDH+EDj/bYFRvXBiMP2db3LKIMgdLcCOeNagdkN4r4pJy0iFea02QB/4Jwl xMdEv/0t/J3+18c9E7KeerLw86W/a0DqypKBxBRweCBxvB6Yld4mCqls+OXuxXin QWW8SH6PK1OCMDdNZUcZbBNEXEl5tFsSGsFVBO1BRdYF9Pfu84BY2u0gLKDoO2e5 pxfPKJH9lQvrlPdo7Ya5hzYCCg0K4dA72feONSA7pLNXi8qEIsR971qx3S22KJAh uDurQ3zqUuIy3xg2fCF9YAeNXmzeQV300VsP6x+OgZ7aeNmHnXpkcT/R7mgXvmMn mYJCKSpMXAH1y/UfVI4LbKAz3ibEudELQ9RBX2/eZMJ7HYojfkOIBsTKLKO6EToH zkjZJBVrzegOIG4ZWR9fUJ0nte6741IoYWRq3QZ5ns2i9mvznYtcJe02GkLLEIty YAPBLk4ULPSM8Kua/KpjnRM1Kce326D3od7WbL5c+z0cT1QJQlxwnRcj2kfLyKTw Ei7AfsPVINelLwJsDcpgmh5iGRy+5yHmy64cSbX+bZ0yzAcP/qNu+gvjuZR2offL BSz7yG6pBy51i69Mj++v =yGnd -----END PGP SIGNATURE----- --nextPart1737757.o7N78zozgx--