[PATCH] gdb: testsuite: fix ksh shebang to use sh

[PATCH] gdb: testsuite: fix ksh shebang to use sh

[Mike Frysinger]

These scripts use /bin/ksh, but they're dirt simple and can be used with
/bin/sh, so just change the shebang.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

2012-12-03  Mike Frysinger  <vapier@gentoo.org>

	* gdb.hp/gdb.base-hp/so-thresh.sh: Change /bin/ksh to /bin/sh.
	* gdb.hp/gdb.objdbg/tools/symaddr: Likewise.
	* gdb.hp/gdb.objdbg/tools/symaddr.pa64: Likewise.
---
 gdb/testsuite/gdb.hp/gdb.base-hp/so-thresh.sh      | 2 +-
 gdb/testsuite/gdb.hp/gdb.objdbg/tools/symaddr      | 2 +-
 gdb/testsuite/gdb.hp/gdb.objdbg/tools/symaddr.pa64 | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.hp/gdb.base-hp/so-thresh.sh b/gdb/testsuite/gdb.hp/gdb.base-hp/so-thresh.sh
index 6b6d6ec..078e05a 100755
--- a/gdb/testsuite/gdb.hp/gdb.base-hp/so-thresh.sh
+++ b/gdb/testsuite/gdb.hp/gdb.base-hp/so-thresh.sh
@@ -1,4 +1,4 @@
-#!/bin/ksh
+#!/bin/sh
 
 # so-thresh.sh
 #
diff --git a/gdb/testsuite/gdb.hp/gdb.objdbg/tools/symaddr b/gdb/testsuite/gdb.hp/gdb.objdbg/tools/symaddr
index 032bb9f..d358e31 100755
--- a/gdb/testsuite/gdb.hp/gdb.objdbg/tools/symaddr
+++ b/gdb/testsuite/gdb.hp/gdb.objdbg/tools/symaddr
@@ -1,4 +1,4 @@
-#!/bin/ksh
+#!/bin/sh
 
 # Get the address of a symbol in Hex.
 # $1 = object/executable file name
diff --git a/gdb/testsuite/gdb.hp/gdb.objdbg/tools/symaddr.pa64 b/gdb/testsuite/gdb.hp/gdb.objdbg/tools/symaddr.pa64
index 43fd793..4f3c8db 100755
--- a/gdb/testsuite/gdb.hp/gdb.objdbg/tools/symaddr.pa64
+++ b/gdb/testsuite/gdb.hp/gdb.objdbg/tools/symaddr.pa64
@@ -1,4 +1,4 @@
-#!/bin/ksh
+#!/bin/sh
 
 # Get the address of a symbol in Hex.
 # $1 = object/executable file name
-- 
1.8.4.3

Re: [PATCH] gdb: testsuite: fix ksh shebang to use sh

[Pedro Alves]

On 12/05/2013 06:07 AM, Mike Frysinger wrote:
> These scripts use /bin/ksh, but they're dirt simple and can be used with
> /bin/sh, so just change the shebang.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> 
> 2012-12-03  Mike Frysinger  <vapier@gentoo.org>
> 
> 	* gdb.hp/gdb.base-hp/so-thresh.sh: Change /bin/ksh to /bin/sh.
> 	* gdb.hp/gdb.objdbg/tools/symaddr: Likewise.
> 	* gdb.hp/gdb.objdbg/tools/symaddr.pa64: Likewise.

Looks OK to me.

A lot of this gdb.hp/ stuff is probably all rotten beyond
salvation, but that's another story.

Thanks,
-- 
Pedro Alves

Re: [PATCH] gdb: testsuite: fix ksh shebang to use sh

[Tom Tromey]

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> A lot of this gdb.hp/ stuff is probably all rotten beyond
Pedro> salvation, but that's another story.

Yeah, it's never run by any regular developers since all the .exp files
start:

if { ![istarget "hppa*-*-hpux*"] } {
    verbose "HPUX test ignored for non-hppa targets."
    return 0
}

Tom

Re: [PATCH] gdb: testsuite: fix ksh shebang to use sh

[Mark Kettenis]

> From: Tom Tromey <tromey@redhat.com>
> Date: Thu, 05 Dec 2013 12:04:33 -0700
> 
> >>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> A lot of this gdb.hp/ stuff is probably all rotten beyond
> Pedro> salvation, but that's another story.
> 
> Yeah, it's never run by any regular developers since all the .exp files
> start:
> 
> if { ![istarget "hppa*-*-hpux*"] } {
>     verbose "HPUX test ignored for non-hppa targets."
>     return 0
> }

And /bin/sh on HP-UX is pretty crappy.  If you want anything
resembling a POSIX shell /bin/ksh was a much better choice.

I'd suggest to leave these test alone or remove them altogether.

Re: [PATCH] gdb: testsuite: fix ksh shebang to use sh

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 1035 bytes --]

On Thursday 05 December 2013 14:48:12 Mark Kettenis wrote:
> > From: Tom Tromey <tromey@redhat.com>
> > Date: Thu, 05 Dec 2013 12:04:33 -0700
> > 
> > >>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> > Pedro> A lot of this gdb.hp/ stuff is probably all rotten beyond
> > Pedro> salvation, but that's another story.
> > 
> > Yeah, it's never run by any regular developers since all the .exp files
> > start:
> > 
> > if { ![istarget "hppa*-*-hpux*"] } {
> > 
> >     verbose "HPUX test ignored for non-hppa targets."
> >     return 0
> > 
> > }
> 
> And /bin/sh on HP-UX is pretty crappy.  If you want anything
> resembling a POSIX shell /bin/ksh was a much better choice.
> 
> I'd suggest to leave these test alone or remove them altogether.

how crappy is it really though ?  if you look at the scripts, they are dirt 
simple.  symaddr runs a single command in a pipeline and uses positional 
parameters ($1).

so-thresh.sh has two simple if statements and custom variables and that's it.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]