Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: tromey@redhat.com, palves@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: testsuite: fix ksh shebang to use sh
Date: Thu, 05 Dec 2013 21:35:00 -0000	[thread overview]
Message-ID: <201312051635.13628.vapier@gentoo.org> (raw)
In-Reply-To: <201312051948.rB5JmC4I029627@glazunov.sibelius.xs4all.nl>

[-- Attachment #1: Type: Text/Plain, Size: 1035 bytes --]

On Thursday 05 December 2013 14:48:12 Mark Kettenis wrote:
> > From: Tom Tromey <tromey@redhat.com>
> > Date: Thu, 05 Dec 2013 12:04:33 -0700
> > 
> > >>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> > Pedro> A lot of this gdb.hp/ stuff is probably all rotten beyond
> > Pedro> salvation, but that's another story.
> > 
> > Yeah, it's never run by any regular developers since all the .exp files
> > start:
> > 
> > if { ![istarget "hppa*-*-hpux*"] } {
> > 
> >     verbose "HPUX test ignored for non-hppa targets."
> >     return 0
> > 
> > }
> 
> And /bin/sh on HP-UX is pretty crappy.  If you want anything
> resembling a POSIX shell /bin/ksh was a much better choice.
> 
> I'd suggest to leave these test alone or remove them altogether.

how crappy is it really though ?  if you look at the scripts, they are dirt 
simple.  symaddr runs a single command in a pipeline and uses positional 
parameters ($1).

so-thresh.sh has two simple if statements and custom variables and that's it.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2013-12-05 21:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-05  6:07 Mike Frysinger
2013-12-05 15:05 ` Pedro Alves
2013-12-05 19:04   ` Tom Tromey
2013-12-05 19:48     ` Mark Kettenis
2013-12-05 21:35       ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201312051635.13628.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=palves@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox