From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] Fix non-stop regressions caused by "breakpoints always-inserted off" changes
Date: Wed, 08 Oct 2014 10:59:00 -0000 [thread overview]
Message-ID: <87k34au8yc.fsf@codesourcery.com> (raw)
In-Reply-To: <1411657123-16228-4-git-send-email-palves@redhat.com> (Pedro Alves's message of "Thu, 25 Sep 2014 15:58:43 +0100")
Pedro Alves <palves@redhat.com> writes:
[ThunderBird puts this series into a wrong thread, so I don't see it
until today]
The patch looks reasonable to me.
> - /* Don't print a message if in the middle of doing a "step n"
> - operation for n > 1 */
> + /* Notify observers if we finished a "step"-like command, etc. */
> if (target_has_execution
> && last.kind != TARGET_WAITKIND_SIGNALLED
> && last.kind != TARGET_WAITKIND_EXITED
> - && inferior_thread ()->step_multi
> && inferior_thread ()->control.stop_step)
> - goto done;
> + {
> + /* But not if if in the middle of doing a "step n" operation for
^^^^^
Duplicated "if"?
--
Yao (齐尧)
next prev parent reply other threads:[~2014-10-08 10:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 14:58 [PATCH 0/3] Fix non-stop + "breakpoints always-inserted off" regressions Pedro Alves
2014-09-25 14:58 ` [PATCH 1/3] Reduce Hg packet (select remote general thread) bouncing Pedro Alves
2014-09-25 14:58 ` [PATCH 3/3] Fix non-stop regressions caused by "breakpoints always-inserted off" changes Pedro Alves
2014-10-08 10:59 ` Yao Qi [this message]
2014-10-10 12:52 ` Pedro Alves
2014-10-08 11:34 ` Yao Qi
2014-10-10 12:52 ` Pedro Alves
2014-09-25 14:58 ` [PATCH 2/3] PR17431: following execs with "breakpoint always-inserted on" Pedro Alves
2014-10-02 9:12 ` [PATCH 0/3] Fix non-stop + "breakpoints always-inserted off" regressions Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k34au8yc.fsf@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox