From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5897 invoked by alias); 8 Oct 2014 10:59:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5880 invoked by uid 89); 8 Oct 2014 10:59:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Oct 2014 10:59:52 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1XboyD-00047p-7d from Yao_Qi@mentor.com ; Wed, 08 Oct 2014 03:59:49 -0700 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.181.6; Wed, 8 Oct 2014 03:59:48 -0700 From: Yao Qi To: Pedro Alves CC: Subject: Re: [PATCH 3/3] Fix non-stop regressions caused by "breakpoints always-inserted off" changes References: <1411657123-16228-1-git-send-email-palves@redhat.com> <1411657123-16228-4-git-send-email-palves@redhat.com> Date: Wed, 08 Oct 2014 10:59:00 -0000 In-Reply-To: <1411657123-16228-4-git-send-email-palves@redhat.com> (Pedro Alves's message of "Thu, 25 Sep 2014 15:58:43 +0100") Message-ID: <87k34au8yc.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00142.txt.bz2 Pedro Alves writes: [ThunderBird puts this series into a wrong thread, so I don't see it until today] The patch looks reasonable to me. > - /* Don't print a message if in the middle of doing a "step n" > - operation for n > 1 */ > + /* Notify observers if we finished a "step"-like command, etc. */ > if (target_has_execution > && last.kind !=3D TARGET_WAITKIND_SIGNALLED > && last.kind !=3D TARGET_WAITKIND_EXITED > - && inferior_thread ()->step_multi > && inferior_thread ()->control.stop_step) > - goto done; > + { > + /* But not if if in the middle of doing a "step n" operation for ^^^^^ Duplicated "if"? --=20 Yao (=E9=BD=90=E5=B0=A7)