From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] Fix non-stop regressions caused by "breakpoints always-inserted off" changes
Date: Wed, 08 Oct 2014 11:34:00 -0000 [thread overview]
Message-ID: <87fveyu7db.fsf@codesourcery.com> (raw)
In-Reply-To: <1411657123-16228-4-git-send-email-palves@redhat.com> (Pedro Alves's message of "Thu, 25 Sep 2014 15:58:43 +0100")
Pedro Alves <palves@redhat.com> writes:
> - if (signal_print[ecs->event_thread->suspend.stop_signal])
> - {
> - /* The signal table tells us to print about this signal. */
> - printed = 1;
> - target_terminal_ours_for_output ();
> - observer_notify_signal_received (ecs->event_thread->suspend.stop_signal);
> - }
> /* Always stop on signals if we're either just gaining control
> of the program, or the user explicitly requested this thread
> to remain stopped. */
> @@ -4214,10 +4207,17 @@ handle_signal_stop (struct execution_control_state *ecs)
> stop_waiting (ecs);
> return;
> }
> - /* If not going to stop, give terminal back
> - if we took it away. */
> - else if (printed)
The use of local variable 'printed' is removed by this patch. We can
remove 'printed' too, as the patch below does. It is obvious, and I'll
push it in.
--
Yao (齐尧)
Subject: [PATCH] Remove unused local variable
As a result of commit b57bacec, local variable 'printed' is no longer
used. This patch is to remove it.
gdb:
2014-10-08 Yao Qi <yao@codesourcery.com>
* infrun.c (handle_signal_stop): Remove local variable 'printed'.
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 7b43785..4681175 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -4425,7 +4425,6 @@ handle_signal_stop (struct execution_control_state *ecs)
if (random_signal)
{
/* Signal not for debugging purposes. */
- int printed = 0;
struct inferior *inf = find_inferior_pid (ptid_get_pid (ecs->ptid));
enum gdb_signal stop_signal = ecs->event_thread->suspend.stop_signal;
next prev parent reply other threads:[~2014-10-08 11:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 14:58 [PATCH 0/3] Fix non-stop + "breakpoints always-inserted off" regressions Pedro Alves
2014-09-25 14:58 ` [PATCH 1/3] Reduce Hg packet (select remote general thread) bouncing Pedro Alves
2014-09-25 14:58 ` [PATCH 3/3] Fix non-stop regressions caused by "breakpoints always-inserted off" changes Pedro Alves
2014-10-08 10:59 ` Yao Qi
2014-10-10 12:52 ` Pedro Alves
2014-10-08 11:34 ` Yao Qi [this message]
2014-10-10 12:52 ` Pedro Alves
2014-09-25 14:58 ` [PATCH 2/3] PR17431: following execs with "breakpoint always-inserted on" Pedro Alves
2014-10-02 9:12 ` [PATCH 0/3] Fix non-stop + "breakpoints always-inserted off" regressions Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fveyu7db.fsf@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox