From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Handle var_zuinteger and var_zuinteger_unlimited from Python
Date: Wed, 02 May 2018 21:07:00 -0000 [thread overview]
Message-ID: <87k1sl6a2e.fsf@tromey.com> (raw)
In-Reply-To: <2ccd62eb-35be-9f7c-64bf-c0fd4a2ed31a@redhat.com> (Pedro Alves's message of "Wed, 2 May 2018 19:16:16 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> On 04/26/2018 11:20 PM, Tom Tromey wrote:
>> + if {$kind == "PARAM_ZUINTEGER"} {
>> + gdb_test "python test_param_$kind.value = -1" "RuntimeError: Range exceeded.*"
>> + } else {
>> + gdb_test_no_output "python test_param_$kind.value = -1" ""
Pedro> Passing "" to gdb_test_no_output case suppresses the test
Pedro> name/message in gdb.sum. I suspect that was not intended.
How's this?
Tom
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 5bbcb2f420..9addcbb9e9 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
2018-05-02 Tom Tromey <tom@tromey.com>
+ * gdb.python/py-parameter.exp: Set test message.
+
+2018-05-02 Tom Tromey <tom@tromey.com>
+
PR python/20084:
* gdb.python/py-parameter.exp: Add PARAM_ZUINTEGER and
PARAM_ZUINTEGER_UNLIMITED tests.
diff --git a/gdb/testsuite/gdb.python/py-parameter.exp b/gdb/testsuite/gdb.python/py-parameter.exp
index b9ff9f1ec0..1ea79b8946 100644
--- a/gdb/testsuite/gdb.python/py-parameter.exp
+++ b/gdb/testsuite/gdb.python/py-parameter.exp
@@ -197,7 +197,8 @@ foreach kind {PARAM_ZUINTEGER PARAM_ZUINTEGER_UNLIMITED} {
if {$kind == "PARAM_ZUINTEGER"} {
gdb_test "python test_param_$kind.value = -1" "RuntimeError: Range exceeded.*"
} else {
- gdb_test_no_output "python test_param_$kind.value = -1" ""
+ gdb_test_no_output "python test_param_$kind.value = -1" \
+ "check that PARAM_ZUINTEGER value can be set to -1"
gdb_test "python print(gdb.parameter('test-$kind'))" "-1" \
"check that PARAM_ZUINTEGER value is -1 after setting"
}
next prev parent reply other threads:[~2018-05-02 21:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 22:20 Tom Tromey
2018-04-27 6:36 ` Eli Zaretskii
2018-05-02 16:01 ` Tom Tromey
2018-05-02 16:06 ` Tom Tromey
2018-05-02 16:26 ` Eli Zaretskii
2018-05-02 16:31 ` Tom Tromey
2018-04-30 21:52 ` Joel Brobecker
2018-05-02 16:05 ` Tom Tromey
2018-05-02 16:25 ` Joel Brobecker
2018-05-02 18:16 ` Pedro Alves
2018-05-02 21:07 ` Tom Tromey [this message]
2018-05-02 21:37 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1sl6a2e.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox