From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51494 invoked by alias); 2 May 2018 21:07:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51476 invoked by uid 89); 2 May 2018 21:07:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=how's, hows X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (50.116.125.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 May 2018 21:07:24 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 72B024591 for ; Wed, 2 May 2018 16:07:22 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id DyyAfHkW9bXuJDyyAfd4eZ; Wed, 02 May 2018 16:07:22 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:59754 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fDyyA-0045Aa-7Y; Wed, 02 May 2018 16:07:22 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Handle var_zuinteger and var_zuinteger_unlimited from Python References: <20180426222003.9059-1-tom@tromey.com> <2ccd62eb-35be-9f7c-64bf-c0fd4a2ed31a@redhat.com> Date: Wed, 02 May 2018 21:07:00 -0000 In-Reply-To: <2ccd62eb-35be-9f7c-64bf-c0fd4a2ed31a@redhat.com> (Pedro Alves's message of "Wed, 2 May 2018 19:16:16 +0100") Message-ID: <87k1sl6a2e.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fDyyA-0045Aa-7Y X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya) [97.122.176.117]:59754 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00024.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 04/26/2018 11:20 PM, Tom Tromey wrote: >> + if {$kind == "PARAM_ZUINTEGER"} { >> + gdb_test "python test_param_$kind.value = -1" "RuntimeError: Range exceeded.*" >> + } else { >> + gdb_test_no_output "python test_param_$kind.value = -1" "" Pedro> Passing "" to gdb_test_no_output case suppresses the test Pedro> name/message in gdb.sum. I suspect that was not intended. How's this? Tom diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 5bbcb2f420..9addcbb9e9 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2018-05-02 Tom Tromey + * gdb.python/py-parameter.exp: Set test message. + +2018-05-02 Tom Tromey + PR python/20084: * gdb.python/py-parameter.exp: Add PARAM_ZUINTEGER and PARAM_ZUINTEGER_UNLIMITED tests. diff --git a/gdb/testsuite/gdb.python/py-parameter.exp b/gdb/testsuite/gdb.python/py-parameter.exp index b9ff9f1ec0..1ea79b8946 100644 --- a/gdb/testsuite/gdb.python/py-parameter.exp +++ b/gdb/testsuite/gdb.python/py-parameter.exp @@ -197,7 +197,8 @@ foreach kind {PARAM_ZUINTEGER PARAM_ZUINTEGER_UNLIMITED} { if {$kind == "PARAM_ZUINTEGER"} { gdb_test "python test_param_$kind.value = -1" "RuntimeError: Range exceeded.*" } else { - gdb_test_no_output "python test_param_$kind.value = -1" "" + gdb_test_no_output "python test_param_$kind.value = -1" \ + "check that PARAM_ZUINTEGER value can be set to -1" gdb_test "python print(gdb.parameter('test-$kind'))" "-1" \ "check that PARAM_ZUINTEGER value is -1 after setting" }