Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, 	Simon Marchi <simark@simark.ca>,
		Tom Tromey <tom@tromey.com>
Subject: Re: [PATCHv2] gdb: Add switch to disable DWARF stack unwinders
Date: Wed, 25 Jul 2018 20:07:00 -0000	[thread overview]
Message-ID: <87k1pjyt7p.fsf@tromey.com> (raw)
In-Reply-To: <20180725151842.6443-1-andrew.burgess@embecosm.com> (Andrew	Burgess's message of "Wed, 25 Jul 2018 16:18:42 +0100")

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> The commit message now mentions pr 8434, which is about being able to
Andrew> enable or disable any/all unwinders.  After the discussions on the
Andrew> mailing list, and on IRC I'm still proposing that this patch only
Andrew> allow control of DWARF unwinders.

Thanks for doing this.
I have a couple little nits, but the patch is ok with these fixed.

Andrew> +that support the DWARF unwinders.  Enabling the dwarf unwinders for an\n\

s/dwarf/DWARF/ here.

Andrew> +# Just check that the DWARF unwinders control flag is visible.
Andrew> +gdb_test "maint show dwarf unwinders" \
Andrew> +    "The DWARF stack unwinders are currently (on\|off)\."

The backslashes aren't really doing their work here, I think it should read:

    "The DWARF stack unwinders are currently (on|off)\\."

thanks,
Tom


      parent reply	other threads:[~2018-07-25 20:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 13:46 [PATCH] " Andrew Burgess
2018-07-13 13:54 ` Eli Zaretskii
2018-07-13 15:34 ` Tom Tromey
2018-07-13 22:37   ` Andrew Burgess
2018-07-13 22:57     ` Tom Tromey
2018-07-14 20:36       ` Andrew Burgess
2018-07-16 15:34         ` Tom Tromey
2018-07-14  1:11 ` Simon Marchi
2018-07-14 20:35   ` Andrew Burgess
2018-07-14 21:39     ` Simon Marchi
2018-07-17 13:23       ` Pedro Alves
2018-07-17 13:36 ` Pedro Alves
2018-07-25 15:18 ` [PATCHv2] " Andrew Burgess
2018-07-25 17:09   ` Eli Zaretskii
2018-07-25 20:07   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1pjyt7p.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox