Re: [PATCH] gdb: Add switch to disable DWARF stack unwinders

[Pedro Alves <palves@redhat.com>]

On 07/14/2018 10:39 PM, Simon Marchi wrote:
> On 2018-07-14 04:35 PM, Andrew Burgess wrote:
>>> I don't think this is necessary, if you leave the "show" callback to NULL,
>>> I think the message is clear enough:
>>>
>>> (gdb) maintenance show dwarf unwinders
>>> Whether the DWARF stack frame unwinders are used is on.
>>
>> I thought that was no longer the approved approach as the resulting
>> string is generated and not internationalised?
> 
> Ah, I was not aware of that.  If you got that from a trustworthy source, then
> I won't object :).
Here:

 void
 deprecated_show_value_hack (struct ui_file *ignore_file,
 			    int ignore_from_tty,
 			    struct cmd_list_element *c,
 			    const char *value)
 {
 ...
   /* Print doc minus "show" at start.  */
   print_doc_line (gdb_stdout, c->doc + 5);
 
That "c->doc + 5" trick only works in English.

Thanks,
Pedro Alves