From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87490 invoked by alias); 17 Jul 2018 13:23:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87474 invoked by uid 89); 17 Jul 2018 13:23:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=trustworthy X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jul 2018 13:23:52 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EFD497DAC6; Tue, 17 Jul 2018 13:23:50 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 03A43178BF; Tue, 17 Jul 2018 13:23:49 +0000 (UTC) Subject: Re: [PATCH] gdb: Add switch to disable DWARF stack unwinders To: Simon Marchi , Andrew Burgess References: <20180713134629.27011-1-andrew.burgess@embecosm.com> <20180714203510.GC2888@embecosm.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <41628b49-fed1-717e-2072-189270c7433d@redhat.com> Date: Tue, 17 Jul 2018 13:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00513.txt.bz2 On 07/14/2018 10:39 PM, Simon Marchi wrote: > On 2018-07-14 04:35 PM, Andrew Burgess wrote: >>> I don't think this is necessary, if you leave the "show" callback to NULL, >>> I think the message is clear enough: >>> >>> (gdb) maintenance show dwarf unwinders >>> Whether the DWARF stack frame unwinders are used is on. >> >> I thought that was no longer the approved approach as the resulting >> string is generated and not internationalised? > > Ah, I was not aware of that. If you got that from a trustworthy source, then > I won't object :). Here: void deprecated_show_value_hack (struct ui_file *ignore_file, int ignore_from_tty, struct cmd_list_element *c, const char *value) { ... /* Print doc minus "show" at start. */ print_doc_line (gdb_stdout, c->doc + 5); That "c->doc + 5" trick only works in English. Thanks, Pedro Alves