From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48379 invoked by alias); 25 Jul 2018 20:07:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48365 invoked by uid 89); 25 Jul 2018 20:07:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.196.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jul 2018 20:07:56 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 08650400D778C for ; Wed, 25 Jul 2018 14:09:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id iQ4hf4vklaSeyiQ4hffToL; Wed, 25 Jul 2018 15:07:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KwKfYGaNZ5U2+yW8JGFJYnS3yU5rZFwV23cVtTdc9TE=; b=NUiIHbuSK8HQuWz4TwyZAPhG/z Aibre+4Ay58SXl6Wzj1OdATwf87idk/Mp1Oqk3yqYE5E/Q0Y4DXVvgKD6yoH81k+jNrvmn+dRDBqO KeYCnAuVaODL5dncWs3qKxk5o; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:37028 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fiQ4h-003Snh-8L; Wed, 25 Jul 2018 15:07:55 -0500 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Simon Marchi , Tom Tromey Subject: Re: [PATCHv2] gdb: Add switch to disable DWARF stack unwinders References: <20180713134629.27011-1-andrew.burgess@embecosm.com> <20180725151842.6443-1-andrew.burgess@embecosm.com> Date: Wed, 25 Jul 2018 20:07:00 -0000 In-Reply-To: <20180725151842.6443-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Wed, 25 Jul 2018 16:18:42 +0100") Message-ID: <87k1pjyt7p.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00709.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> The commit message now mentions pr 8434, which is about being able to Andrew> enable or disable any/all unwinders. After the discussions on the Andrew> mailing list, and on IRC I'm still proposing that this patch only Andrew> allow control of DWARF unwinders. Thanks for doing this. I have a couple little nits, but the patch is ok with these fixed. Andrew> +that support the DWARF unwinders. Enabling the dwarf unwinders for an\n\ s/dwarf/DWARF/ here. Andrew> +# Just check that the DWARF unwinders control flag is visible. Andrew> +gdb_test "maint show dwarf unwinders" \ Andrew> + "The DWARF stack unwinders are currently (on\|off)\." The backslashes aren't really doing their work here, I think it should read: "The DWARF stack unwinders are currently (on|off)\\." thanks, Tom