From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv2 1/2] gdb: fix 'list' for multiple source file results
Date: Thu, 04 Dec 2025 09:48:46 -0700 [thread overview]
Message-ID: <87jyz25h1t.fsf@tromey.com> (raw)
In-Reply-To: <b532a1958937b2f8cccbfa534c19fe5fbf307ea0.1763548233.git.aburgess@redhat.com> (Andrew Burgess's message of "Wed, 19 Nov 2025 10:32:37 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> I'm not a fan of using '0' as a special pc value, there are embedded
Andrew> targets where 0 is a valid pc value, but given we're already using 0
Andrew> here, I propose to just roll with it.
A lot to dislike here -- SALs, gdb's code-at-0 handling, and the fact
that some targets even allow this :-)
Andrew> So, my proposal is that, if the pc is 0, add_sal_to_sals should always
Andrew> add the sal. This fixes the decode_digits_list_mode, but should keep
Andrew> the fix that c7a45b98a614 introduced.
Seems reasonable to me. And of course for 17 as well.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2025-12-04 16:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 10:28 [PATCH 0/2] Fix regression in 'list' command Andrew Burgess
2025-11-18 10:28 ` [PATCH 1/2] gdb: fix 'list' for multiple source file results Andrew Burgess
2025-11-18 10:42 ` Andreas Schwab
2025-11-18 14:28 ` Andrew Burgess
2025-11-18 10:28 ` [PATCH 2/2] gdb: display a symbol more often in multi-file list output Andrew Burgess
2025-11-19 10:32 ` [PATCHv2 0/2] Fix regression in 'list' command Andrew Burgess
2025-11-19 10:32 ` [PATCHv2 1/2] gdb: fix 'list' for multiple source file results Andrew Burgess
2025-12-04 16:48 ` Tom Tromey [this message]
2025-12-05 10:50 ` Andrew Burgess
2025-12-04 20:18 ` Kevin Buettner
2025-12-05 7:14 ` Eli Zaretskii
2025-11-19 10:32 ` [PATCHv2 2/2] gdb: display a symbol more often in multi-file list output Andrew Burgess
2025-12-04 16:53 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyz25h1t.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox