From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5STQD5G7MWnjRBkAWB0awg (envelope-from ) for ; Thu, 04 Dec 2025 11:49:21 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kPD5L9OX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 30C731E08D; Thu, 04 Dec 2025 11:49:21 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AC4A81E08D for ; Thu, 04 Dec 2025 11:49:20 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2E0B94BCA420 for ; Thu, 4 Dec 2025 16:49:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2E0B94BCA420 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kPD5L9OX Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 1E4FF4BA2E04 for ; Thu, 4 Dec 2025 16:48:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E4FF4BA2E04 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E4FF4BA2E04 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764866934; cv=none; b=vcgjwgYxOxIb2db0fNfb5durjOIrFx6/mWyX9hOSmePvoEKxrUjYdNHhpbrdfg2HTAmfOMjv0Vwj4E70T8G4ENtDjRD99o0CD0+CKbVvsdNWW4Q7Pj21dUp9wk+6XzG1Hp3WMFfVmZIftZ0c0wEMsy77ByHCT7zcqGoAXt7dONw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764866934; c=relaxed/simple; bh=gSzBXo+cicX2QyfE+/Grr/aeMntx4h8y+y16HLKg4dY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AujdfxyY6/r8aP5w4K+5lInEGvcuH6gf7BwfPYZHGreOrmL1TcGOQcd3aHEZ3usV6dTt2dlKl/PQ90NQn6+JCUywltI00mcenNJsYU6VAkHJhNVnboK3LIbP9Z851CmaYp3LhZx0I/8o44aoDTBfIRX/9P8xKPxAvSJdIbF6HP0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1E4FF4BA2E04 Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id RAtIvEAFVSkcfRCVhvQCSL; Thu, 04 Dec 2025 16:48:53 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id RCVhvLR218RQgRCVhvAIRq; Thu, 04 Dec 2025 16:48:53 +0000 X-Authority-Analysis: v=2.4 cv=aNjwqa9m c=1 sm=1 tr=0 ts=6931bb75 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=wP3pNCr1ah4A:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=7cEK6aQvo3arcSMvig8A:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FYD7LXhZrLpoi5C86AcKu8JT7R1FUVkRbRrJEIfTubg=; b=kPD5L9OXH9/pjBvykNOXp4g0zB Df99h+3JlsyelmzZqPY5DzBfVWkhZjAHXMr/bOn3+zrmGGCuA2DMJkeXIAhSNC5cH2f+FquizzcwG ySzqJnFUW5alBB6COw9SWcmun; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:46254 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vRCVe-00000001rTl-3Pfg; Thu, 04 Dec 2025 09:48:50 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2 1/2] gdb: fix 'list' for multiple source file results In-Reply-To: (Andrew Burgess's message of "Wed, 19 Nov 2025 10:32:37 +0000") References: X-Attribution: Tom Date: Thu, 04 Dec 2025 09:48:46 -0700 Message-ID: <87jyz25h1t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vRCVe-00000001rTl-3Pfg X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:46254 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFQUs0qxlbFt6YjvSjvXRVkpGGmErbNBxReLh9L30Ea3Q0kBkUiFcZQ7iUpFWY5XzBf7Mf6q29cuiyGcADg4SpUrz/jGKXLM7xM7QFLOd4IAYHMs6fO5 FW3xnLtaNHDCrFB2yeu9ecrej59f6j5NV8293Wbx0VlWaSiBnjkzmuatrpyJwnL7Y/ZLTmHvxNAEAq1aN3QMb/M7IhKS9xNGdNc= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> I'm not a fan of using '0' as a special pc value, there are embedded Andrew> targets where 0 is a valid pc value, but given we're already using 0 Andrew> here, I propose to just roll with it. A lot to dislike here -- SALs, gdb's code-at-0 handling, and the fact that some targets even allow this :-) Andrew> So, my proposal is that, if the pc is 0, add_sal_to_sals should always Andrew> add the sal. This fixes the decode_digits_list_mode, but should keep Andrew> the fix that c7a45b98a614 introduced. Seems reasonable to me. And of course for 17 as well. Approved-By: Tom Tromey Tom