Re: [PATCHv2 1/2] gdb: fix 'list' for multiple source file results

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>
> Andrew> I'm not a fan of using '0' as a special pc value, there are embedded
> Andrew> targets where 0 is a valid pc value, but given we're already using 0
> Andrew> here, I propose to just roll with it.
>
> A lot to dislike here -- SALs, gdb's code-at-0 handling, and the fact
> that some targets even allow this :-)
>
> Andrew> So, my proposal is that, if the pc is 0, add_sal_to_sals should always
> Andrew> add the sal.  This fixes the decode_digits_list_mode, but should keep
> Andrew> the fix that c7a45b98a614 introduced.
>
> Seems reasonable to me.  And of course for 17 as well.
> Approved-By: Tom Tromey <tom@tromey.com>

Thanks everyone for the reviews.

Patch #1 is pushed to master and gdb-17-branch.

Patch #2 pushed only to master (not needed for gdb-17-branch).

Thanks,
Andrew