From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2WUgJP64MmmlWBoAWB0awg (envelope-from ) for ; Fri, 05 Dec 2025 05:50:38 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iUBCtC3W; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8AB841E08D; Fri, 05 Dec 2025 05:50:38 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AD27B1E08D for ; Fri, 05 Dec 2025 05:50:37 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 39F924C900C4 for ; Fri, 5 Dec 2025 10:50:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 39F924C900C4 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iUBCtC3W Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id E31F74BCA41B for ; Fri, 5 Dec 2025 10:50:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E31F74BCA41B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E31F74BCA41B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764931813; cv=none; b=eOoltuc/ZtCjcxAEREEYculMjVyBTAOY2o+ptsJleDjsnaIBsa4Z/k8RugE9eA6fMGBtNqma2Dlm/eCP1wluFTznb2jcq2435BeywTqui1wIPvMOR7RY4f3g3iTm/D3me6r/svxCj/DOTJFIwO9Xnsz5b137UEwc00PxcJlfw1w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764931813; c=relaxed/simple; bh=pZHZtiCtvUg1uKa/eUnKR7EYCanWDe0fpVV9/pfDf6w=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=mnJFGDPrE3wcLyctqavlcTMM5ecNXkRAzUYobNaTD7E2BY3NHmowflDZmHvLDFd9Zer6GNE6cDEIadA8+RYr0MAYr2zMzmnBY1f1Fh6Vyec5Rj5Hg+kFVzPNmJHQSSXF9JOaH8CPFBatF4P3lMwDMJx+6Db7cPY1PjJ83HsspZY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E31F74BCA41B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764931812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=igoS40Of1rs7MIdpGprMA6OsjB/KRh/evo1ingLgJ4c=; b=iUBCtC3WhWkMNhaMMeQiWzEDm6uDpR+dEwXe3jD7iaBxDfv2uplgtPti/5d32Qa8TPiZdI 06oObjs8wMOye5oQvCnyR7noRkBUEFEJVsSRmBq8XfcmL9O6XGTA9ivtbKxYhE1i8ezm4u CiaycUq6VnyekA7JPOAHAxkdgmn/Zjo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-NGEDeO1DM5SMmkqkOypYlQ-1; Fri, 05 Dec 2025 05:50:11 -0500 X-MC-Unique: NGEDeO1DM5SMmkqkOypYlQ-1 X-Mimecast-MFC-AGG-ID: NGEDeO1DM5SMmkqkOypYlQ_1764931810 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-47788165c97so12044905e9.0 for ; Fri, 05 Dec 2025 02:50:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764931810; x=1765536610; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=igoS40Of1rs7MIdpGprMA6OsjB/KRh/evo1ingLgJ4c=; b=Zs6c2wxXm+6AlBI+nQCvh05/pe+OUibMfS3emqaE7yT+FSwT9znvZrpNfCVbFAoiTH K/btbJxXS+auUAgC65w7XJEWdJ1ggMaofkBPHKBRcN9GgItxiP6bIIsGWk5FT/5RhOJY LJZb2I6+IzTMGetFDppgHzJLjRNB+kIoeqQmwSEvrf2ieXOQ/VpdzwCh7e1Mxv6S9DFY vmJERzYgKM9dvg9Lm8EXQ1fB2D/YH7jLQl9z8ARIfDV2zLB/Pj7/AnbI6cgRp0C6ovVb LXPQQYtJwj5SH81OLACjE3Dks2uxOkjIGJq6vVl7n2vDROG7gTSp0WsiZ48YISS3/ogH xVbQ== X-Gm-Message-State: AOJu0YyyWq0WfaFOaxmpYww5WrO7D+J4SagvGdaG7walyPhQqx+wOA2Y EO9W8434G1NHpXH4ufXqqODe7LnvYvupCwRP/BJ6MBumvu/4cNCfyIJSso2R0KQ5grPZA+41LJx uuDXd61gPT1oGQY6hTGooNxVeySLfKUiTfTWbkiPtzAFChpsfnfeg6rB8La9vdZkyABBPY80= X-Gm-Gg: ASbGnctAz0ygFR8ryPEsVE0lVkA3azyt+/hnXJDT37OYRpjNUdhS3dwA3NWeU+kYQe3 ZbE3D8T9+WbYrfL76PvXmPORGZ4cibKY8xu9DYCKQdgyxO6bK4W1N1zzSWbLyRpAwdLptHwZQH3 8+nT7xj48AaGLyJZibIcZdmZQiHn5RdS9dynRsC6mpmjPNK2ut1MEVUGhGv6vfU6LaS0/arUG1C uOnI/waVcgDIraoTEZLHdJMSUDKiNj1JXFoeR7viKvJ6QG+OOTzcLn+vxTsf9K5+NcQNaLKcVHR IyaP2eAXWRdYfV9PiqvKQHYT3AxLi/W+ozRqvTL0zF8WFir9BNrja7eCdsaY8LL3+oMCoYg2bKF 3PVPb X-Received: by 2002:a05:600c:4504:b0:477:55ce:f3c3 with SMTP id 5b1f17b1804b1-4792aee3941mr83164405e9.5.1764931809803; Fri, 05 Dec 2025 02:50:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/vwVKbG3dYEF0WDJEdhphTGptIjyr0ctxqvlgseRJTF2mSuQzdxrj0Z2BdhqxTunyE+G/iA== X-Received: by 2002:a05:600c:4504:b0:477:55ce:f3c3 with SMTP id 5b1f17b1804b1-4792aee3941mr83164305e9.5.1764931809446; Fri, 05 Dec 2025 02:50:09 -0800 (PST) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4793091c740sm74192135e9.3.2025.12.05.02.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 02:50:09 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2 1/2] gdb: fix 'list' for multiple source file results In-Reply-To: <87jyz25h1t.fsf@tromey.com> References: <87jyz25h1t.fsf@tromey.com> Date: Fri, 05 Dec 2025 10:50:08 +0000 Message-ID: <87ikelqk2n.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QHgtHQlhgjWNwWIzxBYsaO_B76eply2kRAiq2FolPEI_1764931810 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> I'm not a fan of using '0' as a special pc value, there are embedded > Andrew> targets where 0 is a valid pc value, but given we're already using 0 > Andrew> here, I propose to just roll with it. > > A lot to dislike here -- SALs, gdb's code-at-0 handling, and the fact > that some targets even allow this :-) > > Andrew> So, my proposal is that, if the pc is 0, add_sal_to_sals should always > Andrew> add the sal. This fixes the decode_digits_list_mode, but should keep > Andrew> the fix that c7a45b98a614 introduced. > > Seems reasonable to me. And of course for 17 as well. > Approved-By: Tom Tromey Thanks everyone for the reviews. Patch #1 is pushed to master and gdb-17-branch. Patch #2 pushed only to master (not needed for gdb-17-branch). Thanks, Andrew