Re: [PATCH v4 12/13] gdb: Enable signal trampolines in the shadow stack backtrace.

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Christina Schimpe <christina.schimpe@intel.com> writes:

> Similar to the normal backtrace we now print "<signal handler called>"
> in the shadow stack backtrace, too.
>
> ~~~
> (gdb) bt -shadow
> /#0  <signal handler called>
> /#1  <sigframe token>
> /#2  0x00007ffff7c4527e in __GI_raise at ../sysdeps/posix/raise.c:26
> /#3  0x0000555555555175 in main at /tmp/gdb.arch/amd64-shadow-stack-signal.c:29
> (gdb) bt
> /#0  handler (signo=10) at /tmp/amd64-shadow-stack-signal.c:23
> /#1  <signal handler called>
> /#2  __pthread_kill_implementation (no_tid=0, signo=10, threadid=<optimized out>) at ./nptl/pthread_kill.c:44
> /#3  __pthread_kill_internal (signo=10, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
> /#4  __GI___pthread_kill (threadid=<optimized out>, signo=signo@entry=10) at ./nptl/pthread_kill.c:89
> /#5  0x00007ffff7c4527e in __GI_raise (sig=10) at ../sysdeps/posix/raise.c:26
> /#6  0x0000555555555175 in main ()
>     at /tmp/amd64-shadow-stack-signal.c:29
> ~~~
> ---
>  gdb/amd64-linux-tdep.c                        | 36 +++++++++++--------
>  gdb/gdbarch-gen.c                             | 32 +++++++++++++++++
>  gdb/gdbarch-gen.h                             | 11 ++++++
>  gdb/gdbarch_components.py                     | 13 +++++++
>  gdb/shadow-stack.c                            | 11 ++++++
>  gdb/shadow-stack.h                            |  5 +++
>  .../amd64-shadow-stack-backtrace-signal.exp   |  2 +-
>  7 files changed, 95 insertions(+), 15 deletions(-)

Great!

Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>

-- 
Thiago
(he/him)